Re: [PATCH] [3/4] x86: MCE: Improve mce_get_rip

Andi Kleen
2009-04-10T08:23:43Z

On Fri, Apr 10, 2009 at 01:38:07PM +0900, Hidetoshi Seto wrote:
> Andi Kleen wrote:
> >> Following is a proposal version. Maybe dividing it into 2 pieces, function
> >> improvement and MSR definition, would be a good idea.
> >
> > I don't think we need the full MSR definitions right now, at least
> > I don't have any plans to support them. After all current CPUs
> > don't.
> >
> > The rest looks good.
>
> Thanks.
>
> I still believe that using MSR which only available on 32bit from 64bit

The MSR is available on 64bit too (there are 64bit capable P4s
like Prescott or Smithfield)

> code is not right thing. However this is not logical bug, and adding
> definition is not suitable for 2.6.30. I'd like to defer the MSR part
> to the next time.
>
> BTW, since this patch is "Improve", I think you need to clarify why you
> bind it into the "bugfix" patch set for 2.6.30. If there are known bug,
> please describe about it.

It reports the incorrect RIP, fixing one of the test cases in the
MCE regression test suite.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.