Re: [PATCH 3/4] PCI: PCIE AER: PCIE AER software error injection

[Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>]

Huang Ying wrote:
> Debugging PCIE AER code can be very difficult because it is hard to
> trigger various real hardware errors. This patch provide a software
> based error injection tool, which can fake various PCIE errors with a
> user space helper tool named "aer-inject". Which can be gotten from:
> 
>   http://www.kernel.org/pub/linux/kernel/people/yhuang/
> 
> The patch fakes AER error by faking some PCIE AER related registers
> and an AER interrupt for specified the PCIE device.
> 
> Signed-off-by: Huang Ying <ying.huang@intel.com>
> 
> ---
>  drivers/pci/pcie/aer/Kconfig       |    2 
>  drivers/pci/pcie/aer/Kconfig.debug |   18 +
>  drivers/pci/pcie/aer/Makefile      |    1 
>  drivers/pci/pcie/aer/aer_inject.c  |  472 +++++++++++++++++++++++++++++++++++++
>  4 files changed, 493 insertions(+)
> 
> --- /dev/null
> +++ b/drivers/pci/pcie/aer/aer_inject.c
> @@ -0,0 +1,472 @@
> +/*
> + * PCIE AER software error injection support.
> + *
> + * Debuging PCIE AER code is quite difficult because it is hard to
> + * trigger various real hardware errors. Software based error
> + * injection can fake almost all kinds of errors with the help of a
> + * user space helper tool aer-inject, which can be gotten from:
> + *   http://www.kernel.org/pub/utils/pcie/aer-inject

Shouldn't it be 

http://www.kernel.org/pub/linux/kernel/people/yhuang/

?

(snip.)

> --- /dev/null
> +++ b/drivers/pci/pcie/aer/Kconfig.debug
> @@ -0,0 +1,18 @@
> +#
> +# PCI Express Root Port Device AER Debug Configuration
> +#
> +
> +config PCIEAER_INJECT
> +	tristate "PCIE AER error injector support"
> +	depends on PCIEAER
> +	default n
> +	help
> +	  This enables PCI Express Root Port Advanced Error Reporting
> +	  (AER) software error injector.
> +
> +	  Debuging PCIE AER code is quite difficult because it is hard
> +	  to trigger various real hardware errors. Software based
> +	  error injection can fake almost all kinds of errors with the
> +	  help of a user space helper tool aer-inject, which can be
> +	  gotten from:
> +	     http://www.kernel.org/pub/utils/pcie/aer-inject
> 

Ditto.

Thanks,
Kenji Kaneshige