public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@csr.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Kernel development list <linux-kernel@vger.kernel.org>
Subject: dma_debug_device_change() gives bogus errors
Date: Fri, 24 Apr 2009 12:20:04 +0100	[thread overview]
Message-ID: <49F1A064.6040100@csr.com> (raw)

dma_debug_device_change() gives bogus errors if a driver unmaps dma
buffers within its driver->remove() method.  This is because the
BUS_NOTIFY_UNBIND_DRIVER notification is raised before calling
driver->remove() (see __device_release_driver() in drivers/base/dd.c).

By the time my driver->remove() completes, there are no DMA mappings
(debug_dma_dump_mappings() produces no output).

Also, somewhat surprisingly, it only prints the error the first time the
driver is unbound.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/

             reply	other threads:[~2009-04-24 11:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 11:20 David Vrabel [this message]
2009-04-24 12:18 ` dma_debug_device_change() gives bogus errors Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F1A064.6040100@csr.com \
    --to=david.vrabel@csr.com \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox