From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbZDZEJR (ORCPT ); Sun, 26 Apr 2009 00:09:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750957AbZDZEI6 (ORCPT ); Sun, 26 Apr 2009 00:08:58 -0400 Received: from hera.kernel.org ([140.211.167.34]:48295 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbZDZEI6 (ORCPT ); Sun, 26 Apr 2009 00:08:58 -0400 Message-ID: <49F3DE55.8070302@kernel.org> Date: Sun, 26 Apr 2009 13:08:53 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Jeff Garzik CC: Bartlomiej Zolnierkiewicz , unsik Kim , linux-kernel@vger.kernel.org, Linux IDE mailing list Subject: Re: [PATCH 2/3] mg_disk: fix dependency on libata References: <200904251509.11912.bzolnier@gmail.com> <49F3D994.7020304@kernel.org> <49F3DCD5.2070909@garzik.org> In-Reply-To: <49F3DCD5.2070909@garzik.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Sun, 26 Apr 2009 04:07:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeff Garzik wrote: > Actually... NVMHCI[1] uses the same style of id string extraction, even > though its command set is wholly new and unrelated to ATA. I copied > into drivers/block/nvmhci.c[2] id_string, id_c_string and another > useful, generic routine: ata_wait_register. > > So, once nvmhci goes upstream, that will be a third copy... nvmhci > still has rough edges, but it's mainly waiting on hardware "it works" > verification at this point. For two copies, copying seems to be the right way to go. For many more copies, making a library function is. Three is a difficult number. Maybe just make these inline functions for now? Thanks. -- tejun