Re: [PATCH 2/2] regulator: add userspace-consumer driver

[Mike Rapoport <mike@compulab.co.il>]

Mark Brown wrote:
> On Sun, Apr 26, 2009 at 12:17:23PM +0300, Mike Rapoport wrote:
> 
>> +/*
>> + * line-consumer.c
> 
> Bitrot.

Thanks, I'll fix it.

> 
>> +	for (i = 0; i < drvdata->num_supplies; i++)
>> +		drvdata->supplies[i].supply = pdata->supplies[i].supply;
> 
> ...
> 
>> +struct regulator_userspace_consumer_data {
>> +	const char *name;
>> +
>> +	int num_supplies;
>> +	struct regulator_consumer_supply *supplies;
> 
> Why are you using a regulator_consumer_supply here?  All that's being
> used here is the name and I can't see why you'd want the device.

For upwards compatibility :)
Well, seriously, I think using 'struct regulator_consumer_supply *supplies'
rather than 'char *supplies' makes the platform code that registers the
userspace-consumer device clearer.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Sincerely yours,
Mike.