From: Benny Halevy <bhalevy@panasas.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Fred Isaman <iisaman@citi.umich.edu>,
Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Re: [PATCH] lib: find_last_bit.o needed by a module only, move it from lib to obj
Date: Sun, 26 Apr 2009 17:13:54 +0300 [thread overview]
Message-ID: <49F46C22.7020401@panasas.com> (raw)
In-Reply-To: <20090426131422.GA19701@infradead.org>
On Apr. 26, 2009, 16:14 +0300, Christoph Hellwig <hch@infradead.org> wrote:
> On Sun, Apr 26, 2009 at 10:05:19PM +0930, Rusty Russell wrote:
>> On Thu, 23 Apr 2009 11:10:32 pm Benny Halevy wrote:
>>> From: Fred Isaman <iisaman@citi.umich.edu>
>>>
>>> Currently, although find_last_bit is EXPORTed, it is statically linked with
>>> the lernel and is referenced only under CONFIG_SMP.
>> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>>
>> We know that any EXPORT_SYMBOL in lib-y is dubious, at least, but we're
>> lazy (ISTR it would gut lib-y to exclude them all).
>
> The whole of lib-y is dangerous and we should just kill it..
>
Why isn't it a standalone module?
Benny
prev parent reply other threads:[~2009-04-26 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 13:40 [PATCH] lib: find_last_bit.o needed by a module only, move it from lib to obj Benny Halevy
2009-04-26 12:35 ` Rusty Russell
2009-04-26 13:14 ` Christoph Hellwig
2009-04-26 14:13 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F46C22.7020401@panasas.com \
--to=bhalevy@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=hch@infradead.org \
--cc=iisaman@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox