Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update

Michal Simek
2009-04-27T12:44:48Z

Arnd Bergmann wrote:
> On Monday 27 April 2009, Michal Simek wrote:
>>> long st_size; /* Size of file, in bytes. */
>> Maybe unsigned? Make more sense to me that file size is not minus.
>> And for some types below.
>
> st_size represents an off_t in user space, which is signed.
> Just over half the existing architectures use signed types
> for st_size, but for this (like Sam's suggestion for __u64),
> I don't think it matters either way.

OK. Is it mean that your structure is perfect? If yes, I'll recompile toolchain and do some more tests.

Michal

>
> Arnd <><

--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854