Re: [PATCH 30/30] microblaze_mmu_v1: fcntl.h MMU update

John Williams
2009-04-27T10:06:17Z

Michal,

On Mon, Apr 27, 2009 at 7:59 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Apr 27, 2009 at 10:32:19AM +0200, monstr@monstr.eu wrote:
>> From: Michal Simek <monstr@monstr.eu>
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> ---
>>  arch/microblaze/include/asm/fcntl.h |   14 ++++++++++++++
>>  1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/microblaze/include/asm/fcntl.h b/arch/microblaze/include/asm/fcntl.h
>> index 46ab12d..b4d27f6 100644
>> --- a/arch/microblaze/include/asm/fcntl.h
>> +++ b/arch/microblaze/include/asm/fcntl.h
>> @@ -1 +1,15 @@
>> +#ifndef _ASM_MICROBLAZE_FCNTL_H
>> +#define _ASM_MICROBLAZE_FCNTL_H
>> +
>> +#ifndef __uClinux__
>> +
>> +#define O_DIRECTORY  040000 /* must be a directory */
>> +#define O_NOFOLLOW   0100000 /* don't follow links */
>> +#define O_LARGEFILE  0200000
>> +#define O_DIRECT     0400000 /* direct disk access hint */
>> +
>> +#endif /* __uClinux__ */
>> +
>>  #include <asm-generic/fcntl.h>
>
> Again, ABIs should always be the same for MMU vs noMMU.

Is there a reason you need these custom fcntls? What if you rebuild
glibc against the newer kernel headers (without __uClinux__)?

John