Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update

Christoph Hellwig
2009-04-27T11:30:41Z

On Mon, Apr 27, 2009 at 12:35:51PM +0200, Michal Simek wrote:
> types and I would like to know about more info.
> For example
> If make sense long long type for st_blocks. IMHO unsigned will be better.
> And I would like to create new stat64 structure where is not a fault for both noMMU/MMU version.
> In noMMU implementation is st_blocks unsigned long. Is it OK? or unsigned long long is better?

You want unsigned long long for it. Take a look at e.g. the xtensa
stat.h and just reuse that one. We should probaly create an
asm-generic/stat.h that new architectures can simply use..

Given that microblaze only got merged in the 2.6.30 window I would
suggest fixing up the nommu variant.