Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update

Arnd Bergmann
2009-04-27T12:56:36Z

On Monday 27 April 2009, Sam Ravnborg wrote:
> The reason I had was:
> 1) consistency. We say that we should use the width specific types in our interfaces
> 2) readability. We expect to see the kernel types used - so we know then and does not
>                 start to wonder why we did not use them here.
> 3) documentation. The __{u,s}{32,64} documents the size better than "unsigned int" / long long" etc.
>
> But no technical atrong arguments.

Well, these are good points, I guess. I'm about to post a series
that adds generic headers for all the ABI. I'm not adapting them
all for this, but it might be a good idea, considering that the
asm-generic headers have a documentation character as well, meaning
that they should serve as an example for how to write new headers.