Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update

Arnd Bergmann
2009-04-27T12:54:19Z

On Monday 27 April 2009, Michal Simek wrote:
> Long answer: in stat64 structure I wanted to find out more information
> about stat64 structure. I mean there are some variables and they have different
> types and I would like to know about more info.
> For example
> If make sense long long type for st_blocks. IMHO unsigned will be better.
> And I would like to create new stat64 structure where is not a fault for both noMMU/MMU version.
> In noMMU implementation is st_blocks unsigned long. Is it OK? or unsigned long long is better?
>

I still think that there are major changes that should be done to the
Microblaze ABI. I actually did most of the work for this, but then you
beat be by getting it upstream first ;-)

I suppose it's much too late for 2.6.30 now, but maybe we can do one major
ABI change to microblaze by making the ABI totally generic in the next
merge window. I'll follow up with an RFC for this.