* [PATCH] regulator: Move regulator drivers to subsys_initcall()
@ 2009-04-27 17:21 Mark Brown
2009-04-28 5:18 ` Mike Rapoport
2009-04-28 11:18 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2009-04-27 17:21 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-kernel, Mark Brown
Regulators need to be available early in init in order to allow them
to be available for consumers when requested. This is generally done
by registering them at subsys_initcall() time but not all regulator
drivers have done that. Convert these drivers to do so in order to
mimimise future support.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/da903x.c | 2 +-
drivers/regulator/fixed.c | 2 +-
drivers/regulator/pcf50633-regulator.c | 2 +-
drivers/regulator/wm8400-regulator.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
index 72b1549..2a491bf 100644
--- a/drivers/regulator/da903x.c
+++ b/drivers/regulator/da903x.c
@@ -504,7 +504,7 @@ static int __init da903x_regulator_init(void)
{
return platform_driver_register(&da903x_regulator_driver);
}
-module_init(da903x_regulator_init);
+subsys_initcall(da903x_regulator_init);
static void __exit da903x_regulator_exit(void)
{
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index 23d5546..6e0bede 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -117,7 +117,7 @@ static int __init regulator_fixed_voltage_init(void)
{
return platform_driver_register(®ulator_fixed_voltage_driver);
}
-module_init(regulator_fixed_voltage_init);
+subsys_initcall(regulator_fixed_voltage_init);
static void __exit regulator_fixed_voltage_exit(void)
{
diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers/regulator/pcf50633-regulator.c
index cd761d8..8e14900 100644
--- a/drivers/regulator/pcf50633-regulator.c
+++ b/drivers/regulator/pcf50633-regulator.c
@@ -316,7 +316,7 @@ static int __init pcf50633_regulator_init(void)
{
return platform_driver_register(&pcf50633_regulator_driver);
}
-module_init(pcf50633_regulator_init);
+subsys_initcall(pcf50633_regulator_init);
static void __exit pcf50633_regulator_exit(void)
{
diff --git a/drivers/regulator/wm8400-regulator.c b/drivers/regulator/wm8400-regulator.c
index 1574260..01a6c95 100644
--- a/drivers/regulator/wm8400-regulator.c
+++ b/drivers/regulator/wm8400-regulator.c
@@ -380,7 +380,7 @@ static int __init wm8400_regulator_init(void)
{
return platform_driver_register(&wm8400_regulator_driver);
}
-module_init(wm8400_regulator_init);
+subsys_initcall(wm8400_regulator_init);
static void __exit wm8400_regulator_exit(void)
{
--
1.6.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: Move regulator drivers to subsys_initcall()
2009-04-27 17:21 [PATCH] regulator: Move regulator drivers to subsys_initcall() Mark Brown
@ 2009-04-28 5:18 ` Mike Rapoport
2009-04-28 11:18 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2009-04-28 5:18 UTC (permalink / raw)
To: Mark Brown; +Cc: Liam Girdwood, linux-kernel
Mark Brown wrote:
> Regulators need to be available early in init in order to allow them
> to be available for consumers when requested. This is generally done
> by registering them at subsys_initcall() time but not all regulator
> drivers have done that. Convert these drivers to do so in order to
> mimimise future support.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/da903x.c | 2 +-
> drivers/regulator/fixed.c | 2 +-
> drivers/regulator/pcf50633-regulator.c | 2 +-
> drivers/regulator/wm8400-regulator.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index 72b1549..2a491bf 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -504,7 +504,7 @@ static int __init da903x_regulator_init(void)
> {
> return platform_driver_register(&da903x_regulator_driver);
> }
> -module_init(da903x_regulator_init);
> +subsys_initcall(da903x_regulator_init);
For DA903x part
Acked-by: Mike Rapoport <mike@compulab.co.il>
> static void __exit da903x_regulator_exit(void)
> {
> diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
> index 23d5546..6e0bede 100644
> --- a/drivers/regulator/fixed.c
> +++ b/drivers/regulator/fixed.c
> @@ -117,7 +117,7 @@ static int __init regulator_fixed_voltage_init(void)
> {
> return platform_driver_register(®ulator_fixed_voltage_driver);
> }
> -module_init(regulator_fixed_voltage_init);
> +subsys_initcall(regulator_fixed_voltage_init);
>
> static void __exit regulator_fixed_voltage_exit(void)
> {
> diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers/regulator/pcf50633-regulator.c
> index cd761d8..8e14900 100644
> --- a/drivers/regulator/pcf50633-regulator.c
> +++ b/drivers/regulator/pcf50633-regulator.c
> @@ -316,7 +316,7 @@ static int __init pcf50633_regulator_init(void)
> {
> return platform_driver_register(&pcf50633_regulator_driver);
> }
> -module_init(pcf50633_regulator_init);
> +subsys_initcall(pcf50633_regulator_init);
>
> static void __exit pcf50633_regulator_exit(void)
> {
> diff --git a/drivers/regulator/wm8400-regulator.c b/drivers/regulator/wm8400-regulator.c
> index 1574260..01a6c95 100644
> --- a/drivers/regulator/wm8400-regulator.c
> +++ b/drivers/regulator/wm8400-regulator.c
> @@ -380,7 +380,7 @@ static int __init wm8400_regulator_init(void)
> {
> return platform_driver_register(&wm8400_regulator_driver);
> }
> -module_init(wm8400_regulator_init);
> +subsys_initcall(wm8400_regulator_init);
>
> static void __exit wm8400_regulator_exit(void)
> {
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: Move regulator drivers to subsys_initcall()
2009-04-27 17:21 [PATCH] regulator: Move regulator drivers to subsys_initcall() Mark Brown
2009-04-28 5:18 ` Mike Rapoport
@ 2009-04-28 11:18 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2009-04-28 11:18 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel, Mike Rapoport
On Mon, 2009-04-27 at 18:21 +0100, Mark Brown wrote:
> Regulators need to be available early in init in order to allow them
> to be available for consumers when requested. This is generally done
> by registering them at subsys_initcall() time but not all regulator
> drivers have done that. Convert these drivers to do so in order to
> mimimise future support.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/da903x.c | 2 +-
> drivers/regulator/fixed.c | 2 +-
> drivers/regulator/pcf50633-regulator.c | 2 +-
> drivers/regulator/wm8400-regulator.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-28 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-27 17:21 [PATCH] regulator: Move regulator drivers to subsys_initcall() Mark Brown
2009-04-28 5:18 ` Mike Rapoport
2009-04-28 11:18 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox