public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Huang Ying <ying.huang@intel.com>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer
Date: Tue, 28 Apr 2009 12:33:21 +0200	[thread overview]
Message-ID: <49F6DB71.10709@linux.intel.com> (raw)
In-Reply-To: <1240914103.7620.110.camel@twins>


> We're talking about Machine Check Exceptions here, right? 

No, this is actually more about machine check events (CMCI or poll), not int #18.

> Is there a
> valid scenario where you care about performance? 

Yes corrected errors. They just get reported while the system
keep running.

In practice they can happen in bursts for a relatively short time.
Another case was dumb QA setups where people using high frequency
injection of corrected errors (that was one case the old code didn't handle
too well). Yes I would agree with you that long term high frequency is
not an interesting case still.

However there's another reason why this patchkit is very useful. The old
code didn't scale to a large number of CPUs, that is why the per CPU
buffers are needed.

> Also, it sounds like something that might fit the ftrace ringbuffer
> thingy.

We went over this before. Please read this relevant threads.

-Andi

      reply	other threads:[~2009-04-28 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28  9:27 [PATCH -v2] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer Huang Ying
2009-04-28 10:21 ` Andi Kleen
2009-04-29  1:31   ` Huang Ying
2009-04-29  6:11     ` Andi Kleen
2009-04-29  6:50       ` Huang Ying
2009-04-28 10:21 ` Peter Zijlstra
2009-04-28 10:33   ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F6DB71.10709@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox