From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] x86: cleanup alternative.h
Date: Tue, 28 Apr 2009 10:40:09 -0700 [thread overview]
Message-ID: <49F73F79.7060809@zytor.com> (raw)
In-Reply-To: <20090428145839.GA26546@elte.hu>
Ingo Molnar wrote:
>
> Please try to align both the continuation backslashes and the
> comments vertically. Something like:
>
>> +#define ALTERNATIVE(oldinstr, newinstr, feature) \
>> + \
>> + "661:\n\t" oldinstr "\n662:\n" \
>> + ".section .altinstructions,\"a\"\n" \
>> + _ASM_ALIGN "\n" \
>> + _ASM_PTR "661b\n" /* label */ \
>> + _ASM_PTR "663f\n" /* new instruction */ \
>> + " .byte " __stringify(feature) "\n" /* feature bit */ \
>> + " .byte 662b-661b\n" /* sourcelen */ \
>> + " .byte 664f-663f\n" /* replacementlen */ \
>
> ... should do the trick. (also note the extra line after the #define)
>
This formatting seems a bit odd; _ASM_ALIGN, _ASM_PTR, and .section are
functionally equivalent to the opcode field, as is .byte, so the shift
in indentation for the .byte lines seems odd at best.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-04-28 17:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 20:18 [patch 0/2] Fixing AMD cmpxchg "missing lfence" mess Mathieu Desnoyers
2009-04-22 20:18 ` [patch 1/2] x86: cleanup alternative.h Mathieu Desnoyers
2009-04-28 13:05 ` [GIT PULL] " Mathieu Desnoyers
2009-04-28 14:58 ` Ingo Molnar
2009-04-28 15:13 ` [GIT PULL] x86: cleanup alternative.h (v2) Mathieu Desnoyers
2009-04-29 6:17 ` [tip:x86/asm] x86: clean up alternative.h tip-bot for Mathieu Desnoyers
2009-04-29 6:22 ` Mathieu Desnoyers
2009-04-28 17:40 ` H. Peter Anvin [this message]
2009-04-28 18:11 ` [GIT PULL] x86: cleanup alternative.h Mathieu Desnoyers
2009-04-28 18:13 ` [GIT PULL] x86: cleanup alternative.h (v3) Mathieu Desnoyers
2009-04-22 20:18 ` [patch 2/2] x86 amd fix cmpxchg read acquire barrier Mathieu Desnoyers
2009-04-22 20:59 ` Alan Cox
2009-04-22 22:47 ` Mathieu Desnoyers
2009-04-22 22:53 ` Alan Cox
2009-04-22 23:26 ` Mathieu Desnoyers
2009-04-23 8:06 ` Ingo Molnar
2009-04-23 13:19 ` Mathieu Desnoyers
2009-04-23 13:41 ` Arkadiusz Miskiewicz
2009-04-23 22:17 ` Mathieu Desnoyers
2009-04-25 8:19 ` Pavel Machek
2009-05-02 15:55 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F73F79.7060809@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox