public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: No NCQ support on X61s Ultrabay?  (Intel ICH8 SATA controller question)
Date: Thu, 30 Apr 2009 11:19:42 +0900	[thread overview]
Message-ID: <49F90ABE.4040607@kernel.org> (raw)
In-Reply-To: <E1LzLgA-0004j6-9W@closure.thunk.org>

Hello,

Theodore Ts'o wrote:
> [ 4563.614247] ata4.00: 390721968 sectors, multi 16: LBA48 NCQ (depth 0/32)
> 
> which as near as I can tell is because ATA_FLAG_NCQ isn't set in struct
> ata_port->flag.  This looks like it should be set to ata_piix.c if the
> controller supports NCQ --- but ata_piix.c doesn't set ATA_FLAG_NCQ at
> all.  However, this web page:
> 
> 	http://www.intel.com/support/chipsets/imst/sb/CS-012304.htm
> 
> Seems to imply the 82801HBM/HEM SATA controller from the ICH8M/ICHM8-E
> supports AHCI and NCQ, and this is the controller which is in the X61s
> laptop.

The controller can be drive in two different modes - piix and ahci.
In piix mode, it behaves like good old IDE controller from 15 years
back and can't do NCQ.  Looks like your controller is in piix mode.

> So I wonder if it's safe to simply add ATA_FLAG_NCQ to ata_piix.c or
> not?  Can someone who's more familiar with Intel's ICH8 SATA controller
> comment on whether this would be a safe thing to do?

Oh... please don't that.  It won't work.  On ICHs, whether the
controller is put in piix or ahci mode is determined by the BIOS.
Most desktop BIOSen have option to put the controller in different
modes but most laptops don't seem to have such option.

Thanks.

-- 
tejun

  reply	other threads:[~2009-04-30  2:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30  2:07 No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question) Theodore Ts'o
2009-04-30  2:19 ` Tejun Heo [this message]
2009-04-30  2:27 ` Jeff Garzik
2009-04-30  7:33   ` Alex Buell
2009-04-30  7:45     ` Tejun Heo
2009-04-30 13:47       ` Alan Cox
2009-04-30 15:35         ` Matthew Wilcox
2009-04-30 15:47           ` Matthew Garrett
2009-05-01  1:49             ` Robert Hancock
2009-05-03  2:07               ` Tejun Heo
2009-05-03 20:50                 ` Robert Hancock
2009-05-03 22:35                   ` Jason Riedy
2009-04-30 11:34     ` Theodore Tso
2009-04-30 11:38       ` Theodore Tso
2009-05-01  1:51         ` Robert Hancock
2009-05-01  2:51           ` Theodore Tso
2009-05-01  4:21             ` Robert Hancock
2009-05-01 11:35               ` Matthew Wilcox
2009-05-01 13:14                 ` Theodore Tso
2009-05-01 13:59                   ` Matthew Garrett
2009-05-01 14:09                   ` Matthew Wilcox
2009-04-30 15:42       ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F90ABE.4040607@kernel.org \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox