Re: [PATCH 2/5] USB: Provide USB boot device availability notification

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

David VomLehn wrote:

> From: Alan Stern <stern@rowland.harvard.edu>

> Use boot device discovery infrastructure to report availability of USB
> devices.

> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: David VomLehn <dvomlehn@cisco.com>

[...]

> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index be86ae3..01a9b76 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -37,6 +37,20 @@
>  #endif
>  #endif
>  
> +/* The mask of possible USB boot devices depends on what drivers and
> + * options have been configured into the kernel.  There are too many
> + * USB network config options to list here, so just assume it is always
> + * possible to have a USB network device.
> + */
> +static int usb_bootdev_mask = 0
> +#ifdef CONFIG_USB_SERIAL_CONSOLE
> +				| BOOTDEV_CONSOLE_MASK
> +#endif
> +#if defined(CONFIG_USB_STORAGE) | defined(CONFIG_BLK_DEV_UB)

    It should be ||, not bitwise | here, no?

WBR, Sergei