From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: David VomLehn <dvomlehn@cisco.com>,
linux-usb@vger.kernel.org, gregkh@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] USB: Provide USB boot device availability notification
Date: Thu, 30 Apr 2009 19:50:56 +0400 [thread overview]
Message-ID: <49F9C8E0.30808@ru.mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0904301131530.20151-100000@netrider.rowland.org>
Alan Stern wrote:
>>>+/* The mask of possible USB boot devices depends on what drivers and
>>>+ * options have been configured into the kernel. There are too many
>>>+ * USB network config options to list here, so just assume it is always
>>>+ * possible to have a USB network device.
>>>+ */
>>>+static int usb_bootdev_mask = 0
>>>+#ifdef CONFIG_USB_SERIAL_CONSOLE
>>>+ | BOOTDEV_CONSOLE_MASK
>>>+#endif
>>>+#if defined(CONFIG_USB_STORAGE) | defined(CONFIG_BLK_DEV_UB)
>> It should be ||, not bitwise | here, no?
> No, it should be bitwise |. The value being constructed is a union of
> disjoint mask bits.
I meant the #if line only. Although it shouldn't matter really...
> Alan Stern
WBR, Sergei
next prev parent reply other threads:[~2009-04-30 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 0:09 [PATCH 2/5] USB: Provide USB boot device availability notification David VomLehn
2009-04-30 15:25 ` Sergei Shtylyov
2009-04-30 15:32 ` Alan Stern
2009-04-30 15:50 ` Sergei Shtylyov [this message]
2009-04-30 19:24 ` Alan Stern
2009-04-30 19:49 ` David VomLehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F9C8E0.30808@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=dvomlehn@cisco.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox