From: "Alan D. Brunelle" <Alan.Brunelle@hp.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizf@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <srostedt@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jens Axboe <jens.axboe@oracle.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: Subject: [PATCH] from-sector redundant in trace_block_remap
Date: Fri, 01 May 2009 08:41:28 -0400 [thread overview]
Message-ID: <49FAEDF8.5040506@hp.com> (raw)
In-Reply-To: <2f11576a0904301908i1c0f12e5tc3f76e1ffee84a18@mail.gmail.com>
KOSAKI Motohiro wrote:
>> From f167379b6c2cbad5f4fe8492052693825980ec19 Mon Sep 17 00:00:00 2001
>> From: Alan D. Brunelle <alan.brunelle@hp.com>
>> Date: Thu, 30 Apr 2009 11:22:55 -0400
>> Subject: [PATCH] from-sector redundant in trace_block_remap
>>
>> Removed redundant from-sector parameter: it's /always/ the bio's sector
>> passed in.
>
> please swap patch 1/2 and 2/2.
> Actually this patch remove "to" parameter. but wrong parameter name
> confuse patch description.
>
> IOW, this patch description and changing code isn't consistent because
> there is argument to-from swapping.
> Otherthings, looks good to me.
Very good point - will re-work & re-submit.
Thanks,
Alan
next prev parent reply other threads:[~2009-05-01 12:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 4:37 [PATCH] blktrace: swap arg name "from" and "to" of blk_add_trace_remap KOSAKI Motohiro
2009-04-30 6:47 ` Ingo Molnar
2009-04-30 16:56 ` Alan D. Brunelle
2009-04-30 16:58 ` Subject: [PATCH] from-sector redundant in trace_block_remap Alan D. Brunelle
2009-05-01 2:08 ` KOSAKI Motohiro
2009-05-01 12:41 ` Alan D. Brunelle [this message]
2009-05-04 5:46 ` Li Zefan
2009-04-30 16:59 ` [PATCH] blktrace: correct remap names Alan D. Brunelle
2009-05-04 5:47 ` Li Zefan
2009-05-06 9:53 ` Ingo Molnar
2009-05-06 11:30 ` Alan D. Brunelle
2009-05-06 12:10 ` Ingo Molnar
2009-05-01 2:13 ` [PATCH] blktrace: swap arg name "from" and "to" of blk_add_trace_remap KOSAKI Motohiro
2009-05-01 12:44 ` Alan D. Brunelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FAEDF8.5040506@hp.com \
--to=alan.brunelle@hp.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox