public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] menu: fix embedded menu order
Date: Fri, 01 May 2009 09:36:57 -0700	[thread overview]
Message-ID: <49FB2529.2080102@oracle.com> (raw)

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix Embedded menu order/structure.

The "EMBEDDED" menu display is broken, i.e., it is split apart,
not displayed entirely in one place, due to some symbols not being
listed as "if EMBEDDED".  Make them be displayed all together.

Tested with menuconfig, xconfig, & gconfig.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 init/Kconfig |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

--- lnx-2630-rc4.orig/init/Kconfig
+++ lnx-2630-rc4/init/Kconfig
@@ -786,7 +786,7 @@ config KALLSYMS
 	   somewhat, as all symbols have to be loaded into the kernel image.
 
 config KALLSYMS_ALL
-	bool "Include all symbols in kallsyms"
+	bool "Include all symbols in kallsyms" if EMBEDDED
 	depends on DEBUG_KERNEL && KALLSYMS
 	help
 	   Normally kallsyms only contains the symbols of functions, for nicer
@@ -797,7 +797,7 @@ config KALLSYMS_ALL
 	   Say N.
 
 config KALLSYMS_EXTRA_PASS
-	bool "Do an extra kallsyms pass"
+	bool "Do an extra kallsyms pass" if EMBEDDED
 	depends on KALLSYMS
 	help
 	   If kallsyms is not working correctly, the build will fail with
@@ -807,9 +807,8 @@ config KALLSYMS_EXTRA_PASS
 	   reported.  KALLSYMS_EXTRA_PASS is only a temporary workaround while
 	   you wait for kallsyms to be fixed.
 
-
 config STRIP_ASM_SYMS
-	bool "Strip assembler-generated symbols during link"
+	bool "Strip assembler-generated symbols during link" if EMBEDDED
 	default n
 	help
 	  Strip internal assembler-generated symbols during a link (symbols
@@ -961,6 +960,9 @@ config SLUB_DEBUG
 	  SLUB sysfs support. /sys/slab will not exist and there will be
 	  no support for cache validation etc.
 
+# end EMBEDDED menu -- don't put non-EMBEDDED items between
+# "menuconfig EMBEDDED" and here.
+
 config COMPAT_BRK
 	bool "Disable heap randomization"
 	default y

                 reply	other threads:[~2009-05-01 16:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49FB2529.2080102@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox