Re: [PATCH] reiserfs: Expand i_mutex to enclose lookup_one_len

Jeff Mahoney
2009-05-01T20:37:16Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Morton wrote:
> On Fri, 01 May 2009 12:11:12 -0400
> Jeff Mahoney <jeffm@suse.com> wrote:
>
>> 2.6.30-rc3 introduced some sanity checks in the VFS code to avoid NFS
>> bugs by ensuring that lookup_one_len is always called under i_mutex.
>>
>> This patch expands the i_mutex locking to enclose lookup_one_len. This was
>> always required, but not not enforced in the reiserfs code since it
>> does locking around the xattr interactions with the xattr_sem.
>
> cool, so this will fix all those backtraces people have been reporting
> coming out of the reiserfs xattr code lately?

Yes.

>> This is obvious enough, but it survived an overnight 50 thread ACL test.
>
> That sounds a bit pessimistic. I think I'll s/but/and/ ;)

Yeah, that's more accurate. :)

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkn7XU4ACgkQLPWxlyuTD7JOAgCfcVV+kowmYbaBKNCZG7BfNx3V
9dwAoKGB7Uu2RkwXtkpaaCi2ADtQszC1
=B4is
-----END PGP SIGNATURE-----