From: Helge Deller <deller@gmx.de>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: Tim Abbott <tabbott@MIT.EDU>, Sam Ravnborg <sam@ravnborg.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Anders Kaseorg <andersk@MIT.EDU>, Waseem Daher <wdaher@MIT.EDU>,
Denys Vlasenko <vda.linux@googlemail.com>,
Jeff Arnold <jbarnold@MIT.EDU>,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH 3/5] parisc: use new macros for .data.init_task.
Date: Sat, 02 May 2009 18:16:38 +0200 [thread overview]
Message-ID: <49FC71E6.4000100@gmx.de> (raw)
In-Reply-To: <20090502141308.GA28342@bombadil.infradead.org>
Kyle McMartin wrote:
> On Sat, May 02, 2009 at 07:13:37AM +0200, Helge Deller wrote:
>> I think this patch is wrong, although it is theoretically correct.
>>
>> IIRC, gcc on hppa is not able to provide an alignment >= 8k, which is
>> why we have done the 16k alignment inside the linker script.
>> So, I think this change will prevent the parisc kernel to boot up.
>> Needs testing.
>>
>
> I think you're confusing this with the 8-byte maximum alignment from
> kmalloc and on-stack that prevents us from just using a 16-byte aligned
> word as a lock on pa1.1?
No, I was not confusing it with the 8byte-alignment.
I really meant that a > 8k alignment was not possible.
I tried exactly the same stuff once and failed.
I think the restriction came from hpux compatibility or some old gas...
Anyway, I just tried some assembly and it seems to work.
> The patch I trimmed from this mail looks correct to me.
If you apply it and it boots OK for you, I'm fine.
Helge
next prev parent reply other threads:[~2009-05-02 16:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 23:55 [PATCH 0/5] section name cleanup for parisc Tim Abbott
2009-04-30 23:55 ` [PATCH 1/5] parisc: use NOSAVE_DATA macro for .data.nosave section Tim Abbott
2009-04-30 23:55 ` [PATCH 2/5] parisc: use new macro for .data.cacheline_aligned section Tim Abbott
2009-04-30 23:55 ` [PATCH 3/5] parisc: use new macros for .data.init_task Tim Abbott
2009-04-30 23:55 ` [PATCH 4/5] parisc: use new macro for .data.read_mostly section Tim Abbott
2009-04-30 23:55 ` [PATCH 5/5] parisc: convert to new generic read_mostly support Tim Abbott
2009-05-02 5:13 ` [PATCH 3/5] parisc: use new macros for .data.init_task Helge Deller
2009-05-02 14:04 ` John David Anglin
2009-05-02 14:13 ` Kyle McMartin
2009-05-02 16:16 ` Helge Deller [this message]
2009-05-02 16:52 ` John David Anglin
2009-05-02 22:10 ` Sam Ravnborg
2009-05-03 19:37 ` Helge Deller
2009-05-02 14:19 ` [PATCH 0/5] section name cleanup for parisc Kyle McMartin
2009-05-02 16:32 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FC71E6.4000100@gmx.de \
--to=deller@gmx.de \
--cc=andersk@MIT.EDU \
--cc=jbarnold@MIT.EDU \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tabbott@MIT.EDU \
--cc=vda.linux@googlemail.com \
--cc=wdaher@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox