[PATCH] staging: &&/|| typo?

[PATCH] staging: &&/|| typo?

[Roel Kluin]

Fix &&/|| typo

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
vi drivers/staging/go7007/wis-sony-tuner.c +218
#define MPX_NUM_MODES   ARRAY_SIZE(mpx_audio_modes)

diff --git a/drivers/staging/go7007/wis-sony-tuner.c b/drivers/staging/go7007/wis-sony-tuner.c
index c965c60..086896c 100644
--- a/drivers/staging/go7007/wis-sony-tuner.c
+++ b/drivers/staging/go7007/wis-sony-tuner.c
@@ -370,7 +370,7 @@ static int set_if(struct i2c_client *client)
 	i2c_transfer(client->adapter, &msg, 1);
 
 	/* Select MPX mode if not forced by the user */
-	if (force_mpx_mode >= 0 || force_mpx_mode < MPX_NUM_MODES)
+	if (force_mpx_mode >= 0 && force_mpx_mode < MPX_NUM_MODES)
 		t->mpxmode = force_mpx_mode;
 	else
 		t->mpxmode = default_mpx_mode;

Re: [PATCH] staging: &&/|| typo?

[Andrew Morton]

On Sat, 02 May 2009 22:46:47 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:

> Subject: [PATCH] staging: &&/|| typo?

nit: if/when this driver gets moved out of staging/, it will still have
a commit titled "staging: &&/|| typo?" in its record.

That title will be pretty useless and meaningless for a driver which
isn't in staging!

So I'd suggest that in general, the "staging" information be included
inside [], so it gets tossed away as the patch is applied.

Also, the title is pretty bad in other ways - it doesn't identify what
part of the kernel is being changed.  At least, not with sufficient
specificity.


So a better title would be, say,

	[patch] [staging] wis-sony-tuner.c: fix &&/|| error