public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Linux-kernel <linux-kernel@vger.kernel.org>
Subject: compat ioctl32 for /dev/snapshot?
Date: Mon, 04 May 2009 13:29:22 +0400	[thread overview]
Message-ID: <49FEB572.4010909@msgid.tls.msk.ru> (raw)

Is there any reason why 32-bit uswsusp &Friends does not work
on 64bits kernel?

For one, 32bits s2disk produces the following when trying to
suspend:

  ioctl32(s2disk:4134): Unknown cmd fd(4) cmd(400c330d){t:'3';sz:12} arg(ff853554) on /dev/snapshot
  ioctl32(s2disk:4134): Unknown cmd fd(4) cmd(4004330a){t:'3';sz:4} arg(00000805) on /dev/snapshot

this is coming from:

     error = ioctl(dev, SNAPSHOT_SET_SWAP_AREA, &swap);
     if (error && !offset)
             error = ioctl(dev, SNAPSHOT_SET_SWAP_FILE, blkdev);

but I guess (just guess!) that other SNAPSHOT_* operations will
also fail the same way.

Is there a reason why those are not in compat_ioctl?

Thanks.

/mjt

             reply	other threads:[~2009-05-04  9:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04  9:29 Michael Tokarev [this message]
2009-05-04  9:35 ` compat ioctl32 for /dev/snapshot? Andi Kleen
2009-05-04 10:55   ` Michael Tokarev
2009-05-04 11:12     ` Andi Kleen
2009-05-04 21:55       ` Rafael J. Wysocki
2009-05-05 11:38         ` Arnd Bergmann
2009-05-05 11:43           ` Michael Tokarev
2009-05-05 23:13             ` Rafael J. Wysocki
2009-05-04 11:52     ` Arnd Bergmann
2009-05-04 22:26       ` Michael Tokarev
2009-05-05 10:58         ` Arnd Bergmann
2009-05-04 21:58 ` Rafael J. Wysocki
2009-07-10 16:21 ` Pavel Machek
2009-07-12  0:19   ` Michael Tokarev
2009-07-12 15:07     ` Arnd Bergmann
2009-07-13  6:51       ` Michael Tokarev
2009-07-13 20:21         ` Pavel Machek
2009-07-14  6:57           ` Michael Tokarev
2009-07-14  9:55             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49FEB572.4010909@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox