* Re: [Ocfs2-devel] Deadlock in dlmmaster.c
[not found] <ef67228d0905031333i782ad1efhe532cd555e58b604@mail.gmail.com>
@ 2009-05-04 19:30 ` Sunil Mushran
0 siblings, 0 replies; only message in thread
From: Sunil Mushran @ 2009-05-04 19:30 UTC (permalink / raw)
To: Jan Kucera; +Cc: mfasheh, joel.becker, linux-fsdevel, linux-kernel, ocfs2-devel
Jan Kucera wrote:
> I've found some possible deadlock in fs/ocfs2/dlm/dlmmaster.c -
> version 2.6.28 (probably this code is in newer versions too).
> Could someone confirm this? Thank you.
>
>
> fs/ocfs2/dlm/dlmmaster.c
> ==================
>
> function dlm_master_request_handler: (res->spinlock <- dlm->master_lock)
> -----------------------------------
> spin_lock(&res->spinlock); at line 1427
> spin_lock(&dlm->master_lock); at line 1475
>
> function dlm_migrate_request_handler: (dlm->master_lock <- res->spinlock)
> -------------------------------------------------------
> spin_lock(&dlm->master_lock) at line 3036
> spin_lock(&res->spinlock); at line 3039
So this should not happen.
The first condition can only be hit if the resource has no master and is in
the process of being mastered.
The second condition will only be hit if the resource has a master and is
currently being migrated (remastered) from one node to another.
The two appear to be mutually exclusive. But feel free to file a bugzilla
so that I remember to look into it more carefully when I have more time.
http://oss.oracle.com/bugzilla
Thanks
Sunil
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-05-04 19:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <ef67228d0905031333i782ad1efhe532cd555e58b604@mail.gmail.com>
2009-05-04 19:30 ` [Ocfs2-devel] Deadlock in dlmmaster.c Sunil Mushran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox