Re: [PATCH 3/6] ksm: change the KSM_REMOVE_MEMORY_REGION ioctl.

Andrea Arcangeli
2009-05-07T11:33:43Z

On Wed, May 06, 2009 at 09:49:45AM -0700, Chris Wright wrote:
> I like merge. For madvise() approach I had used:
>
> +#define MADV_SHAREABLE 12 /* can share identical pages */
> +#define MADV_UNSHAREABLE 13 /* can not share identical pages
>
> But those are maybe better put as MADV_(UN)MERGEABLE (gets a bit confusing when
> you talk of merging vmas ;-)
> */

What this thing does is to create shared pages by merging equal pages...

While I don't care about the naming much myself, one problem I have is
that I've been writing a KSM paper for linuxsymposium and I'd like to
use a nomenclature that is in sync with how this stuff should be
called on lkml, to avoid confusion.

So should I change the simpler word KSM with "Memory Merging feature"
all over the paper?

In addition I consistently use the term "shared KSM pages" often,
should I rename all those instances to "merged pages"? I used the word
'merging' only when describing the operation KSM does when it creates
shared pages, but never to name the generated pages themself.

Thanks,
Andrea