Re: [PATCH 3/6] ksm: change the KSM_REMOVE_MEMORY_REGION ioctl.

Hugh Dickins
2009-05-06T16:59:53Z

On Wed, 6 May 2009, Chris Wright wrote:
>
> I like merge. For madvise() approach I had used:
>
> +#define MADV_SHAREABLE 12 /* can share identical pages */
> +#define MADV_UNSHAREABLE 13 /* can not share identical pages */
>
> But those are maybe better put as MADV_(UN)MERGEABLE
> (gets a bit confusing when you talk of merging vmas ;-)

That's true, I hadn't remembered that. Not _very_ confusing,
but the last thing I'd want is to bully everyone into changing
their familiar name for something, and the result just as poor.
No need to decide today anyway: let's see how others feel.

Hugh