Re: [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES option

OGAWA Hirofumi
2009-05-02T11:59:30Z

tridge@samba.org writes:

> > Yes. I guess -ENAMETOOLONG would not good for !valid, and !(is_shortname
> > && base_info.valid && ext_info.valid) or add "else" part is more prefer
> > though.
>
> ok, new patch below.

Looks good to me as technical stand.

> > Yes. The case-insensitive is ok, the dcache can handle case-insensitive.
>
> good, that makes life simpler :-)
>
> Are you happy with the shortname_flags hackery in
> vfat_create_shortname() ?

Ah. What is the intent to force WINNT option (lcase field)? To force it
may not be good. So, change default if config is on?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>