Re: [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES option

tridge
2009-05-02T11:13:30Z

Hi Hirofumi-san,

> It may be ok. However, of course, it should consider other than
> ascii. Well, I think the patch should be allow only perfect 8.3 name in
> vfat_create_shortname(). (i.e. is_shortname && base/ext_info.valid)

ok, so something like this in vfat_create_shortname() ?

#ifdef CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES
if (is_shortname == 0 ||
!(base_info.valid && ext_info.valid))
return -ENAMETOOLONG;
shortname_flags = VFAT_SFN_CREATE_WINNT;
#endif

that still means that creating a file ShortNam.TxT actually creates
shortnam.txt on disk. Will the case-insensitive vfat_cmpi used as
d_compare cope OK with that?

Cheers, Tridge