From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH] tracing/ftrace: add missing wake-up on some callsites
Date: Sun, 22 Feb 2009 22:56:08 +0100 [thread overview]
Message-ID: <49a1cc8f.2283420a.54d2.ffff8461@mx.google.com> (raw)
Impact: fix unwaken pipe
Now that we use a common wakeup infrastructure, we must append a wakeup
on few callsites which lack it or tasks reading trace_pipe will not be
awaken when events come on few tracers.
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
kernel/trace/trace.c | 2 ++
kernel/trace/trace_branch.c | 2 ++
kernel/trace/trace_hw_branches.c | 2 ++
3 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index e1f3b99..7f450b6 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3055,6 +3055,8 @@ int trace_vprintk(unsigned long ip, int depth, const char *fmt, va_list args)
out:
preempt_enable_notrace();
+ trace_wake_up();
+
return len;
}
EXPORT_SYMBOL_GPL(trace_vprintk);
diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
index c2e68d4..8c8f8c0 100644
--- a/kernel/trace/trace_branch.c
+++ b/kernel/trace/trace_branch.c
@@ -78,6 +78,8 @@ probe_likely_condition(struct ftrace_branch_data *f, int val, int expect)
out:
atomic_dec(&tr->data[cpu]->disabled);
local_irq_restore(flags);
+
+ trace_wake_up();
}
static inline
diff --git a/kernel/trace/trace_hw_branches.c b/kernel/trace/trace_hw_branches.c
index 3561aac..ddd87fd 100644
--- a/kernel/trace/trace_hw_branches.c
+++ b/kernel/trace/trace_hw_branches.c
@@ -202,6 +202,8 @@ void trace_hw_branch(u64 from, u64 to)
out:
atomic_dec(&tr->data[cpu]->disabled);
local_irq_restore(irq1);
+
+ trace_wake_up();
}
static void trace_bts_at(const struct bts_trace *trace, void *at)
--
1.6.1
next reply other threads:[~2009-02-22 22:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-22 21:56 Frederic Weisbecker [this message]
2009-02-22 22:16 ` [PATCH] tracing/ftrace: add missing wake-up on some callsites Ingo Molnar
2009-02-23 15:37 ` Steven Rostedt
2009-02-23 15:42 ` Steven Rostedt
2009-02-23 16:26 ` Frederic Weisbecker
2009-02-23 16:51 ` Steven Rostedt
2009-02-23 17:05 ` Frederic Weisbecker
2009-02-23 17:13 ` Steven Rostedt
2009-02-23 17:34 ` Frederic Weisbecker
2009-02-23 17:37 ` Ingo Molnar
2009-02-23 18:03 ` Steven Rostedt
2009-02-23 18:09 ` Ingo Molnar
2009-02-27 17:04 ` Masami Hiramatsu
2009-02-23 16:22 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a1cc8f.2283420a.54d2.ffff8461@mx.google.com \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox