From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [PATCH 1/2] tracing/core: make the per cpu trace files in per cpu directories
Date: Thu, 26 Feb 2009 00:41:38 +0100 [thread overview]
Message-ID: <49a632a5.0707d00a.296d.24b3@mx.google.com> (raw)
Impact: scale per cpu tracing
The per cpu trace files are all in a single directory: /debug/tracing/per_cpu.
In case of a large number of cpu, the content of this directory becomes messy
so we create now one directory per cpu inside /debug/tracing/per_cpu which contain
each their own trace_pipe and trace files.
Ie:
nobody@nowhere:/debug/tracing$ ls -R per_cpu
per_cpu:
cpu0 cpu1
per_cpu/cpu0:
trace trace_pipe
per_cpu/cpu1:
trace trace_pipe
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
---
kernel/trace/trace.c | 25 ++++++++++++++-----------
1 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index b7eeecc..b1f7105 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3061,28 +3061,31 @@ struct dentry *tracing_dentry_percpu(void)
static void tracing_init_debugfs_percpu(long cpu)
{
struct dentry *d_percpu = tracing_dentry_percpu();
- struct dentry *entry;
- /* strlen(trace_pipe) + MAX(log10(cpu)) + '\0' */
- char filename[17];
+ struct dentry *entry, *d_cpu;
+ /* strlen(cpu) + MAX(log10(cpu)) + '\0' */
+ char cpu_dir[7];
if (cpu > 999 || cpu < 0)
return;
- /* per cpu trace_pipe */
- sprintf(filename, "trace_pipe%ld", cpu);
+ sprintf(cpu_dir, "cpu%ld", cpu);
+ d_cpu = debugfs_create_dir(cpu_dir, d_percpu);
+ if (!d_cpu) {
+ pr_warning("Could not create debugfs '%s' entry\n", cpu_dir);
+ return;
+ }
- entry = debugfs_create_file(filename, 0444, d_percpu,
+ /* per cpu trace_pipe */
+ entry = debugfs_create_file("trace_pipe", 0444, d_cpu,
(void *) cpu, &tracing_pipe_fops);
if (!entry)
- pr_warning("Could not create debugfs '%s' entry\n", filename);
+ pr_warning("Could not create debugfs 'trace_pipe' entry\n");
/* per cpu trace */
- sprintf(filename, "trace%ld", cpu);
-
- entry = debugfs_create_file(filename, 0444, d_percpu,
+ entry = debugfs_create_file("trace", 0444, d_cpu,
(void *) cpu, &tracing_fops);
if (!entry)
- pr_warning("Could not create debugfs '%s' entry\n", filename);
+ pr_warning("Could not create debugfs 'trace' entry\n");
}
--
1.6.1
next reply other threads:[~2009-02-26 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 23:41 Frederic Weisbecker [this message]
2009-02-26 7:06 ` [PATCH 1/2] tracing/core: make the per cpu trace files in per cpu directories Frederic Weisbecker
2009-02-26 13:14 ` Ingo Molnar
2009-02-26 13:22 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a632a5.0707d00a.296d.24b3@mx.google.com \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox