[PATCH] platform/x86/amd_isp4: prevent built-in configuration

[PATCH] platform/x86/amd_isp4: prevent built-in configuration

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Checking the module owner of the device only works when modules are
enabled, and the device is created from a module:

drivers/platform/x86/amd/amd_isp4.c:154:28: error: incomplete definition of type 'struct module'

Building the driver as a loadable module avoids the build failure,
though this should probably be fixed in a different way that still
works if the device was created from built-in code.

Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506150313.UHoIoVhR-lkp@intel.com/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/platform/x86/amd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
index 63e4bd985699..9e150500e37e 100644
--- a/drivers/platform/x86/amd/Kconfig
+++ b/drivers/platform/x86/amd/Kconfig
@@ -36,6 +36,7 @@ config AMD_WBRF
 config AMD_ISP_PLATFORM
 	tristate "AMD ISP4 platform driver"
 	depends on I2C && X86_64 && ACPI
+	depends on m
 	help
 	  Platform driver for AMD platforms containing image signal processor
 	  gen 4. Provides camera sensor module board information to allow
-- 
2.39.5

Re: [PATCH] platform/x86/amd_isp4: prevent built-in configuration

[Nirujogi, Pratap]

Hi Arnd,

Thanks for the patch.

On 6/20/2025 7:54 AM, Arnd Bergmann wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Checking the module owner of the device only works when modules are
> enabled, and the device is created from a module:
> 
> drivers/platform/x86/amd/amd_isp4.c:154:28: error: incomplete definition of type 'struct module'
> 
> Building the driver as a loadable module avoids the build failure,
> though this should probably be fixed in a different way that still
> works if the device was created from built-in code.
> 
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506150313.UHoIoVhR-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/platform/x86/amd/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
> index 63e4bd985699..9e150500e37e 100644
> --- a/drivers/platform/x86/amd/Kconfig
> +++ b/drivers/platform/x86/amd/Kconfig
> @@ -36,6 +36,7 @@ config AMD_WBRF
>   config AMD_ISP_PLATFORM
>          tristate "AMD ISP4 platform driver"
>          depends on I2C && X86_64 && ACPI
> +       depends on m
This issue is reported earlier and the fix has been submitted to replace 
adap->owner->name with adap->name to remove the dependency on 
CONFIG_MODULES. But until the fix is accepted and is available on either 
i2c or pdx86 tree, I think its good to have this fix to avoid the build 
errors.

https://lore.kernel.org/all/20250609155601.1477055-4-pratap.nirujogi@amd.com/

Reviewed-by: Pratap Nirujogi <pratap.nirujogi@amd.com>

Thanks,
Pratap



>          help
>            Platform driver for AMD platforms containing image signal processor
>            gen 4. Provides camera sensor module board information to allow
> --
> 2.39.5
> 

Re: [PATCH] platform/x86/amd_isp4: prevent built-in configuration

[Ilpo Järvinen]

On Fri, 20 Jun 2025, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> Checking the module owner of the device only works when modules are
> enabled, and the device is created from a module:
> 
> drivers/platform/x86/amd/amd_isp4.c:154:28: error: incomplete definition of type 'struct module'
> 
> Building the driver as a loadable module avoids the build failure,
> though this should probably be fixed in a different way that still
> works if the device was created from built-in code.
> 
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506150313.UHoIoVhR-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/platform/x86/amd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
> index 63e4bd985699..9e150500e37e 100644
> --- a/drivers/platform/x86/amd/Kconfig
> +++ b/drivers/platform/x86/amd/Kconfig
> @@ -36,6 +36,7 @@ config AMD_WBRF
>  config AMD_ISP_PLATFORM
>  	tristate "AMD ISP4 platform driver"
>  	depends on I2C && X86_64 && ACPI
> +	depends on m
>  	help
>  	  Platform driver for AMD platforms containing image signal processor
>  	  gen 4. Provides camera sensor module board information to allow
> 

The fix series should finally be on its way to Linus through i2c tree. 
I'm sorry for the unexpected delay in getting the real fix applied.

-- 
 i.