From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andre Edich <andre.edich@microchip.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net v2 2/3] net: phy: smsc: Force predictable MDI-X state on LAN87xx
Date: Fri, 4 Jul 2025 10:16:03 +0200 [thread overview]
Message-ID: <49b49005-e857-445e-8b63-e84cbfdae17b@lunn.ch> (raw)
In-Reply-To: <20250704100031.19f95d3e@fedora.home>
> The patch looks good to me, but I have a few questions. As this
> overrides some configuration on existing HW, and I'm not utra familiar
> with auto-mdix, is there any chance this could cause regressions ?
>
> Especially regarding your patch 3, is there any chance that the PHY is
> strapped in a fixed MDIX mode to address the broken autoneg off mode ?
>
> I'm not saying that strapping is a good solution for that ofc :) it's a
> shame we can't read the strap config :/
This might technically be considered a behaviour change. However there
are few systems which don't support it. It is also independent of
auto-neg, so autoneg off should not be an issue.
I think this is reasonably safe, and if somebody does report a
regression, we can revert the patch.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-07-04 8:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 11:49 [PATCH net v2 0/4] net: phy: smsc: robustness fixes for LAN87xx/LAN9500 Oleksij Rempel
2025-07-03 11:49 ` [PATCH net v2 1/3] net: phy: smsc: Fix Auto-MDIX configuration when disabled by strap Oleksij Rempel
2025-07-04 7:53 ` Maxime Chevallier
2025-07-03 11:49 ` [PATCH net v2 2/3] net: phy: smsc: Force predictable MDI-X state on LAN87xx Oleksij Rempel
2025-07-04 8:00 ` Maxime Chevallier
2025-07-04 8:16 ` Andrew Lunn [this message]
2025-07-03 11:49 ` [PATCH net v2 3/3] net: phy: smsc: Fix link failure in forced mode with Auto-MDIX Oleksij Rempel
2025-07-04 8:23 ` Andrew Lunn
2025-07-09 1:30 ` [PATCH net v2 0/4] net: phy: smsc: robustness fixes for LAN87xx/LAN9500 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49b49005-e857-445e-8b63-e84cbfdae17b@lunn.ch \
--to=andrew@lunn.ch \
--cc=andre.edich@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox