From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753102AbdKFVLW (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Nov 2017 16:11:22 -0500
Received: from mout.web.de ([217.72.192.78]:56645 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752021AbdKFVLT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Nov 2017 16:11:19 -0500
Subject: Re: iSCSI-target: Use common error handling code in
 iscsi_decode_text_input()
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org
Cc: Arun Easi <arun.easi@cavium.com>,
        Bart Van Assche <bart.vanassche@sandisk.com>,
        "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <d36d5072-3e35-da39-bc0f-af15deb630a8@users.sourceforge.net>
 <20171106162549.5b2511db@alans-desktop>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <49e62625-8c1d-5bbe-2ddd-e25e117754db@users.sourceforge.net>
Date: Mon, 6 Nov 2017 22:11:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171106162549.5b2511db@alans-desktop>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:ZHDHhXJJbiSXPz995gNEcFDolN3PExxITj2aaqa2W38zPG0VLcT
 BhIDniDIfh8MvWeHMbSPtLSPvhFR5W6HFPwiRJ5cwKjgfDCquFjBRi+0Pq8eaPsnlNHPs+o
 XDwxQ0QkLtC8bqzt/z0CVAxbadrE2wl5QYqLbSjt5hN6EZ8ccfoAiR3re66fN2+/G6DTp/T
 Bc3GNAhNT0eCD4QiYQ/lA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:lfJZjjNyd50=:YAdjQPM5Lu581JmpoUKq37
 G427fC2rnVvd9wrGrCFmJGQaepu5WpZKBFT/nvnNJe4Ygl0yaAUuiNC+s34JE0bbd90tVNHOL
 DvCzT0ErhjtQoRxvPvZ/NVsENnXb5Im3yT4WlOeT6kmGec52DFrQB46Qtaq9GnOABY7ToZtIq
 +kwRX5h5y11WT9cG3p04F0XI7sXiC08rYJWNOohgtSRBZHJHRcEje05kbh0GfWcGHIuhLrGzz
 SQJyAWA4JwcElvqKYhNZKMuTiTGySSvmLpLeZ+SLtKoQm08MBBsn1rbzC6rqY58dUqKmAqIZk
 dQHpSpnokWGHuT4eahnInHLLTcM8LNd2C669zbVAQSGoO5PtTncGMHQLFxn2Dlj5a3p7+RDrV
 Vkl5wMbcrVOvMLk5fOV8aeN+SCa4EWu4LFjdj/v2QHEnwTl3FjpGEuaGci7WweLQMJCBJOHfR
 Wye3UzlkoUxJbxizxGtcv17cN5I+z9VShf6ws/ZHOU6Y892migLchT9FH4EeXTYchT08ujKHo
 yKhR9VnvekRayVRGQv+8OBm9zCzONUqv/1M2OxVoRyH/wkHH0nYvHXYpSvVpJy7nJy6yEtMpz
 sYJ8XEdOX49K4AYceQA+z2lfbUCIy6i9+CwZcpJyj1axON2dZteKKY6McAaR9cb23Ca+ByaWg
 I2mpsucnhxc00YP3oB0QSkCQnyVeWp6vJtCkX5xbshxQH68M7jrSb3gEONKf7x6rJZwjyPIUC
 M794Dsx3dMdxPCV4fxCIm/J77TTy1I/QEmc9vFcbC0gBGWqMSfoJmKmi/wFfdSUEPskL1YOCn
 fTqEiqNFIc3wiHgO7yvcN7vCsVvmJEknOTXfsf3FIMpmfSDY9A=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
> 
> Why not look at what the C compiler generates before making the code
> less readable ?

* Does the adjusted source code layout fit to information from the section
  “7) Centralized exiting of functions” in the document “coding-style.rst”?

* Would you find a reduction of 16 bytes for the object code useful for
  the affected function implementation?

Regards,
Markus