From: linmiaohe <linmiaohe@huawei.com>
To: Steven Price <steven.price@arm.com>,
"maz@kernel.org" <maz@kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"julien.thierry.kdev@gmail.com" <julien.thierry.kdev@gmail.com>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
"christoffer.dall@arm.com" <christoffer.dall@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"will@kernel.org" <will@kernel.org>,
"andre.przywara@arm.com" <andre.przywara@arm.com>,
"tglx@linutronix.de" <tglx@linutronix.de>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] KVM: vgic: Use wrapper function to lock/unlock all vcpus in kvm_vgic_create()
Date: Thu, 28 Nov 2019 11:16:28 +0000 [thread overview]
Message-ID: <49f3dec1fa65498c84d0344e0ea629ce@huawei.com> (raw)
Steven Price wrote:
>>
>> if (irqchip_in_kernel(kvm))
>> @@ -92,11 +92,8 @@ int kvm_vgic_create(struct kvm *kvm, u32 type)
>Extra context:
>
> /*
> * Any time a vcpu is run, vcpu_load is called which tries to grab the
> * vcpu->mutex. By grabbing the vcpu->mutex of all VCPUs we ensure
>> * that no other VCPUs are run while we create the vgic.
>> */
>
>That comment no longer makes sense here - there's a very similar one already in lock_all_vcpus(). With that removed:
>
>Reviewed-by: Steven Price <steven.price@arm.com>
>
Many thanks for your review. That comment no longer makes sense as you figured out. I will
remove that. Thanks again.
>> ret = -EBUSY;
>> - kvm_for_each_vcpu(i, vcpu, kvm) {
>> - if (!mutex_trylock(&vcpu->mutex))
>> - goto out_unlock;
>> - vcpu_lock_idx = i;
next reply other threads:[~2019-11-28 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 11:16 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-28 9:26 [PATCH v2] KVM: vgic: Use wrapper function to lock/unlock all vcpus in kvm_vgic_create() linmiaohe
2019-11-28 11:04 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49f3dec1fa65498c84d0344e0ea629ce@huawei.com \
--to=linmiaohe@huawei.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox