From: Frank Rowand <frank.rowand@am.sony.com>
To: mingo@redhat.com
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: [patch] RT: calc_load() uses wrong variable to calculate RT load
Date: Tue, 5 May 2009 16:53:14 -0700 [thread overview]
Message-ID: <4A00D16A.3000908@am.sony.com> (raw)
In calc_load() use RT tasks to calculate the RT load.
Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
---
Ingo,
In calc_load():
#ifdef CONFIG_PREEMPT_RT
active_rt_tasks = count_active_rt_tasks();
#endif
but active_rt_tasks is then not used. I have not read through enough code
to verify my supposition, but the obvious use of this variable would be for
the calculation of the RT load average.
If my supposition is correct, this patch fixes the problem.
The patch is compile tested only.
-Frank Rowand
Sony Corporation of America
Index: linux-2.6.29.2/kernel/timer.c
===================================================================
--- linux-2.6.29.2.orig/kernel/timer.c
+++ linux-2.6.29.2/kernel/timer.c
@@ -1249,9 +1249,9 @@ static inline void calc_load(unsigned lo
CALC_LOAD(avenrun[1], EXP_5, active_tasks);
CALC_LOAD(avenrun[2], EXP_15, active_tasks);
#ifdef CONFIG_PREEMPT_RT
- CALC_LOAD(avenrun_rt[0], EXP_1, active_tasks);
- CALC_LOAD(avenrun_rt[1], EXP_5, active_tasks);
- CALC_LOAD(avenrun_rt[2], EXP_15, active_tasks);
+ CALC_LOAD(avenrun_rt[0], EXP_1, active_rt_tasks);
+ CALC_LOAD(avenrun_rt[1], EXP_5, active_rt_tasks);
+ CALC_LOAD(avenrun_rt[2], EXP_15, active_rt_tasks);
#endif
count += LOAD_FREQ;
next reply other threads:[~2009-05-05 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 23:53 Frank Rowand [this message]
2009-05-06 8:44 ` [patch] RT: calc_load() uses wrong variable to calculate RT load Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A00D16A.3000908@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox