Re: [PATCH 1/4] tracing/events: don't say hi when loading the trace event sample

Steven Rostedt
2009-05-06T02:41:29Z

On Wed, 6 May 2009, Li Zefan wrote:

> The sample is useful for testing, and I'm using it. But after
> loading the module, it keeps saying hi every 10 seconds, this may
> be disturbing.
>
> Also Steven said commenting out the "hi" helped in causing races. :)
>
> [ Impact: make testing a bit easier ]
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
> samples/trace_events/trace-events-sample.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/samples/trace_events/trace-events-sample.c b/samples/trace_events/trace-events-sample.c
> index f33b3ba..aabc4e9 100644
> --- a/samples/trace_events/trace-events-sample.c
> +++ b/samples/trace_events/trace-events-sample.c
> @@ -16,10 +16,6 @@ static void simple_thread_func(int cnt)
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(HZ);
> trace_foo_bar("hello", cnt);
> -
> - if (!(cnt % 10))
> - /* It is really important that I say "hi!" */

I guess it is not so important to say hi after all.

-- Steve

> - printk(KERN_EMERG "hi!\n");
> }
>
> static int simple_thread(void *arg)
> --
> 1.5.4.rc3
>
>
>