Re: BUG: failure at mm/nommu.c:518/add_nommu_region()

[Greg Ungerer <gerg@snapgear.com>]

Hi David,

David Howells wrote:
> Can you try the attached patch, please?

Yes, that fixes it :-)

Regards
Greg


> ---
> From: David Howells <dhowells@redhat.com>
> Subject: [PATCH] NOMMU: Don't check vm_region::vm_start is page aligned in add_nommu_region()
> 
> Don't check vm_region::vm_start is page aligned in add_nommu_region() because
> the region may reflect some non-page-aligned mapped file, such as could be
> obtained from RomFS XIP.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
> 
>  mm/nommu.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/mm/nommu.c b/mm/nommu.c
> index cdc6f60..325706b 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -515,8 +515,6 @@ static void add_nommu_region(struct vm_region *region)
>  
>  	validate_nommu_regions();
>  
> -	BUG_ON(region->vm_start & ~PAGE_MASK);
> -
>  	parent = NULL;
>  	p = &nommu_region_tree.rb_node;
>  	while (*p) {
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com