From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760858AbZEGBQB (ORCPT ); Wed, 6 May 2009 21:16:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753386AbZEGBPv (ORCPT ); Wed, 6 May 2009 21:15:51 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:64545 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753358AbZEGBPv (ORCPT ); Wed, 6 May 2009 21:15:51 -0400 Message-ID: <4A023670.8080306@cn.fujitsu.com> Date: Thu, 07 May 2009 09:16:32 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Jason Baron CC: linux-kernel@vger.kernel.org, mingo@elte.hu, Mathieu Desnoyers , fweisbec@gmail.com, rostedt@goodmis.org, zhaolei@cn.fujitsu.com, laijs@cn.fujitsu.com, Li Zefan , randy.dunlap@oracle.com Subject: Re: [PATCH v3] ftrace: add a tracepoint for __raise_softirq_irqoff() References: <49FFDF9C.7040505@cn.fujitsu.com> <20090506134940.GA3129@redhat.com> In-Reply-To: <20090506134940.GA3129@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason Baron wrote: > On Tue, May 05, 2009 at 02:41:32PM +0800, Xiao Guangrong wrote: >> From: Mathieu Desnoyers >> >> This patch is modified from Mathieu Desnoyers' patch. The original patch >> can be found here: >> http://marc.info/?l=linux-kernel&m=123791201816245&w=2 >> This tracepoint can trace the time stamp when softirq action is raised. >> >> Changelog for v1 -> v2: >> 1: Use TRACE_EVENT instead of DEFINE_TRACE >> 2: Move the tracepoint from raise_softirq_irqoff() to >> __raise_softirq_irqoff() >> >> Changelog for v2 -> v3: >> Move the definition of __raise_softifq_irqoff() to .c file when >> CONFIG_TRACEPOINTS is enabled, to avoid recursive includes >> >> Signed-off-by: Mathieu Desnoyers >> Signed-off-by: Xiao Guangrong >> > > hi, > > Could you please add 'docbook' style comments above TRACE_EVENTi()? We > recently added a tracepoint docbook to the -tip and it already contains > an 'irq' chapter, so you just need to add the comments for the raise > softirq tracepoint. Please see: > > http://marc.info/?l=linux-kernel&m=124118471411710&w=2 > Hi Jason: I will add the comments for this tracepoint. thanks! > thanks, > > -Jason > > > >