From: Peter Staubach <staubach@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Eric Paris <eparis@redhat.com>,
Eric Paris <eparis@parisplace.org>,
Christoph Hellwig <hch@lst.de>, Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
serue@us.ibm.com, hpa@zytor.com, sukadev@us.ibm.com,
linux-kernel@vger.kernel.org, jbacik@redhat.com
Subject: Re: [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts
Date: Fri, 08 May 2009 09:53:47 -0400 [thread overview]
Message-ID: <4A04396B.2030800@redhat.com> (raw)
In-Reply-To: <20090507232110.GB27609@linux.vnet.ibm.com>
Sukadev Bhattiprolu wrote:
> | Must be the
> |
> | memset(&opts, 0, sizeof(opts));
> |
> | in devpts_get_sb() (first statement). It should probably set the options to
> | default values for cases where 'data' is NULL.
> |
> | For now, can you try replacing the memset with:
>
> Er. I meant add following lines after the memset().
>
> | opts->mode = DEVPTS_DEFAULT_MODE;
> | opts->ptmxmode = DEVPTS_DEFAULT_PTMX_MODE;
> |
> | Sukadev
With the obvious syntactic changes to account for opts being a
struct as opposed to being a pointer to a struct, these two lines
do seem to make things better.
ps
next prev parent reply other threads:[~2009-05-08 13:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 18:08 [PATCH 0/5][v2] Simplify devpts code Sukadev Bhattiprolu
2009-03-07 18:10 ` Sukadev Bhattiprolu
2009-03-07 18:17 ` Sukadev Bhattiprolu
2009-03-07 18:11 ` [v3][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-03-07 18:11 ` [v3][PATCH 3/5] Move common mknod_ptmx() calls into caller Sukadev Bhattiprolu
2009-03-07 18:12 ` [v3][PATCH 4/5] Remove get_init_pts_sb() Sukadev Bhattiprolu
2009-03-07 18:12 ` [v3][PATCH 5/5] Merge code for single and multiple-instance mounts Sukadev Bhattiprolu
2009-05-07 20:35 ` Eric Paris
2009-05-07 21:24 ` Sukadev Bhattiprolu
2009-05-07 22:33 ` Eric Paris
2009-05-07 23:18 ` [v3][PATCH 5/5] Merge code for single and multiple-instancemounts Sukadev Bhattiprolu
2009-05-07 23:21 ` [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts Sukadev Bhattiprolu
2009-05-08 13:53 ` Peter Staubach [this message]
2009-05-09 3:17 ` Marc Dionne
2009-05-11 22:15 ` Sukadev Bhattiprolu
2009-05-11 22:19 ` H. Peter Anvin
2009-05-11 22:37 ` [v3][PATCH 5/5] Merge code for singleandmultiple-instancemounts Serge E. Hallyn
2009-05-11 22:46 ` H. Peter Anvin
2009-05-11 22:40 ` [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts Andrew Morton
2009-05-11 23:09 ` Eric Paris
2009-05-11 23:00 ` Marc Dionne
2009-03-07 18:14 ` [v3][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-03-07 18:16 ` [v3][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A04396B.2030800@redhat.com \
--to=staubach@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eparis@parisplace.org \
--cc=eparis@redhat.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=jbacik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox