Re: [PATCH 5/8] xen/i386: make sure initial VGA/ISA mappings are not overridden

Ingo Molnar
2009-05-08T10:57:54Z

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>
> arch/x86/mm/init_32.c overrides the ISA/VGA mappings with direct mappings
> which do not have _PAGE_IOMAP set, thereby making the ISA space inaccessible.
>
> This patch adds to the existing hack to make sure the
> pre-constructed ISA mappings are not incorrectly overwritten.
>
> This makes 32-bit dom0 VGA work properly.

I'm wondering, should we add this fix to .30 as well, is there any
relevancy beyond dom0?

> Thanks to Gerd Hoffman for pointing this out.

Please add Reported-by lines in such cases. That way not only does
the reporting get reported prominently, but the tip-bot will Cc:
Gerd too on the commit notification too. (which will sometimes spur
further comments - while a commit hidden somewhere might not)

> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

Please also add impact-footers to all commits you queue up, if you
want me to pull your tree directly. I can only guess at the impact
of this one, is it:

[ Impact: fix dom0-Xen-guest boot crash ]

or:

[ Impact: fix dom0-Xen-guest non-working VGA console ]

?

(Please look at latest tip/master for examples about various impact
lines, their precise format, and what we try to describe in them and
how.)

Thanks,

Ingo