Re: [tip:x86/xen] x86: use flush_tlb_others to implement flush_tlb_all, fix

Ingo Molnar
2009-05-11T15:42:30Z

* Ian Campbell <Ian.Campbell@eu.citrix.com> wrote:

> in any case I would guess that the fix is:
>
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -87,6 +87,7 @@
> #include <asm/cacheflush.h>
> #include <asm/processor.h>
> #include <asm/bugs.h>
> +#include <asm/tlbflush.h>
>
> #include <asm/system.h>
> #include <asm/vsyscall.h>

Guessing is not enough - please review the prototype position. Is it
available on all configs? It is not ...

But even the proper fix runs into that smp_processor_id() bug i just
posted.

Ingo