From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jan Beulich <jbeulich@novell.com>
Cc: Ingo Molnar <mingo@elte.hu>,
the arch/x86 maintainers <x86@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/5] xen/x86-64: clean up warnings aboutIST-using traps
Date: Fri, 08 May 2009 08:23:01 -0700 [thread overview]
Message-ID: <4A044E55.20803@goop.org> (raw)
In-Reply-To: <4A03F947.76EA.0078.0@novell.com>
Jan Beulich wrote:
>> else if (addr == (unsigned long)int3)
>> addr = (unsigned long)xen_int3;
>> - else
>> - WARN_ON(val->ist != 0);
>> + else if (addr == (unsigned long)double_fault ||
>> + addr == (unsigned long)stack_segment) {
>>
>
> I don't think you want to exclude handling stack faults: Ordinary memory
> references using rsp or rbp as the base register will cause these instead
> of general protection faults when the resulting effective address is non-
> canonical.
>
So even usermode memory accesses? Ew. Well, we can run the trap
handler on the normal kernel stack in that case. I'll cook something up.
J
next prev parent reply other threads:[~2009-05-08 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 18:56 [PATCH 2/5] xen/x86-64: clean up warnings about IST-using traps Jeremy Fitzhardinge
2009-05-08 7:20 ` [Xen-devel] [PATCH 2/5] xen/x86-64: clean up warnings aboutIST-using traps Jan Beulich
2009-05-08 8:58 ` Ingo Molnar
2009-05-08 15:31 ` Jeremy Fitzhardinge
2009-05-08 15:23 ` Jeremy Fitzhardinge [this message]
2009-05-08 15:30 ` [Xen-devel] [PATCH 2/5] xen/x86-64: clean up warnings aboutIST-usingtraps Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A044E55.20803@goop.org \
--to=jeremy@goop.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox