Re: [Xen-devel] [PATCH 2/5] xen/x86-64: clean up warnings aboutIST-using traps

[Jeremy Fitzhardinge <jeremy@goop.org>]

Ingo Molnar wrote:
> Yes. Also, patches 1-2-3 really just do the same thing, one fixes 
> the other one. Would be nice to have a single patch for that whole 
> ugly topic of 64-bit Xen not handling ISTs properly.
>   

Well, 1 is sufficient on its own to fix the breakpoint/watchpoint 
problem.  Looks like I need to do something similar with stack.  The 2,3 
are more general cleanups that aren't essential to the functional fix, 
and should definitely be folded together.

> If this was a CPU we'd say "sorry, dont run Linux on it then" ...
>   

??  Guests don't really need IST because all the tricky traps that 
really require it (NMI, MCE, etc) are handled by Xen.  The stack 
exception was an oversight on my part, because I thought it was 
something that would only happen with a bad kernel stack (but I guess 
that's doublefault).

> I've applied the reservation fix to x86/urgent, and the #5 patch to 
> x86/xen (it's more of a cleanup, not a fix for .30, right?).
>   

Right.

    J