From: Jiri Slaby <jirislaby@gmail.com>
To: Karl Relton <karllinuxtest.relton@ntlworld.com>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/wlan-ng: Change KERN_DEBUG or pr_debug to match orig driver
Date: Fri, 08 May 2009 22:25:03 +0200 [thread overview]
Message-ID: <4A04951F.8060703@gmail.com> (raw)
In-Reply-To: <1241812457.6459.2.camel@localhost>
On 05/08/2009 09:54 PM, Karl Relton wrote:
> Change uses of KERN_DEBUG over to pr_debug to match original driver
> where messages are only needed during driver development.
Hmm, but many of them don't fit this rule. Some of them should be
honored a higher level, some of them simply should be left as such,
because we want to see the information.
> --- c/drivers/staging/wlan-ng/prism2mgmt.c 2009-04-30 05:48:16.000000000 +0100
> +++ d/drivers/staging/wlan-ng/prism2mgmt.c 2009-05-08 19:11:11.000000000 +0100
> @@ -1096,7 +1096,7 @@ int prism2mgmt_wlansniff(wlandevice_t *w
> /* Disable monitor mode */
> result = hfa384x_cmd_monitor(hw, HFA384x_MONITOR_DISABLE);
> if (result) {
> - printk(KERN_DEBUG
> + pr_debug(
> "failed to disable monitor mode, result=%d\n",
rather an ERROR or WARNING?
> --- c/drivers/staging/wlan-ng/prism2sta.c 2009-04-30 05:48:16.000000000 +0100
> +++ d/drivers/staging/wlan-ng/prism2sta.c 2009-05-08 19:15:08.000000000 +0100
> @@ -1188,7 +1188,7 @@ static void prism2sta_inf_chinforesults(
> chinforesult->active =
> le16_to_cpu(inf->info.chinforesult.result[n].
> active);
> - printk(KERN_DEBUG
> + pr_debug(
> "chinfo: channel %d, %s level (avg/peak)=%d/%d dB, pcf %d\n",
yeah, useless info for an user (the change is OK), but:
> @@ -1276,7 +1276,7 @@ void prism2sta_processing_defer(struct w
> wlandev->bssid,
> WLAN_BSSID_LEN);
> if (result) {
> - printk(KERN_DEBUG
> + pr_debug(
> "getconfig(0x%02x) failed, result = %d\n",
> HFA384x_RID_CURRENTBSSID, result);
we want likely to know this one.
etc.
next prev parent reply other threads:[~2009-05-08 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 19:54 [PATCH] staging/wlan-ng: Change KERN_DEBUG or pr_debug to match orig driver Karl Relton
2009-05-08 20:25 ` Jiri Slaby [this message]
2009-05-08 20:54 ` Karl Relton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A04951F.8060703@gmail.com \
--to=jirislaby@gmail.com \
--cc=greg@kroah.com \
--cc=karllinuxtest.relton@ntlworld.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox