Re: [PATCH] vmscan: evict use-once pages first

Rik van Riel
2009-04-29T13:31:33Z

Peter Zijlstra wrote:
> On Tue, 2009-04-28 at 19:29 -0400, Rik van Riel wrote:
>
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index eac9577..4c0304e 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -1489,6 +1489,21 @@ static void shrink_zone(int priority, struct zone *zone,
>> nr[l] = scan;
>> }
>>
>> + /*
>> + * When the system is doing streaming IO, memory pressure here
>> + * ensures that active file pages get deactivated, until more
>> + * than half of the file pages are on the inactive list.
>> + *
>> + * Once we get to that situation, protect the system's working
>> + * set from being evicted by disabling active file page aging
>> + * and swapping of swap backed pages. We still do background
>> + * aging of anonymous pages.
>> + */
>> + if (nr[LRU_INACTIVE_FILE] > nr[LRU_ACTIVE_FILE]) {
>> + nr[LRU_ACTIVE_FILE] = 0;
>> + nr[LRU_INACTIVE_ANON] = 0;
>> + }
>> +
>
> Isn't there a hole where LRU_*_FILE << LRU_*_ANON and we now stop
> shrinking INACTIVE_ANON even though it makes sense to.

Only temporarily, until the number of active file pages
is larger than the number of inactive ones.

Think of it as reducing the frequency of shrinking anonymous
pages while the system is near the threshold.

--
All rights reversed.