From: "H. Peter Anvin" <hpa@zytor.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: cpu/proc.c grouping of cpuid in /proc/cpuinfo
Date: Sun, 10 May 2009 21:18:44 -0700 [thread overview]
Message-ID: <4A07A724.9010405@zytor.com> (raw)
In-Reply-To: <1241941217.3200.3.camel@localhost.localdomain>
Jaswinder Singh Rajput wrote:
> Unification of cpuid_level.
> Also added extended_cpuid_level to make it complete.
>
> So cpuid* and cpufeature flag come in same group and /proc/cpuinfo
> looks like on AMD box:
>
> cpuid level : 1
> ext cpuid level : 0x8000001a
> flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow constant_tsc rep_good nonstop_tsc pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch osvw skinit
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Jaswinder,
/proc/cpuinfo is a userspace API. You CANNOT change the format of it
without breaking applications.
Therefore, any change which moves flags between fields or removes fields
is unacceptable. Adding new fields is possible, however.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-05-11 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 7:40 [PATCH -tip] x86: cpu/proc.c grouping of cpuid in /proc/cpuinfo Jaswinder Singh Rajput
2009-05-11 4:18 ` H. Peter Anvin [this message]
2009-05-11 6:27 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A07A724.9010405@zytor.com \
--to=hpa@zytor.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox