Re: [PATCH -tip v5 1/7] x86: instruction decorder API

Gleb Natapov
2009-05-13T15:21:18Z

On Wed, May 13, 2009 at 10:35:55AM -0400, Masami Hiramatsu wrote:
> Gleb Natapov wrote:
> > On Wed, May 13, 2009 at 11:35:16AM +0200, Przemysssaw Paweeeczyk wrote:
> >> On Wed, May 13, 2009 at 10:23, Gleb Natapov <gleb@redhat.com> wrote:
> >>> On Fri, May 08, 2009 at 08:48:42PM -0400, Masami Hiramatsu wrote:
> >>>> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk
> >>>> @@ -0,0 +1,314 @@
> >>>> +#!/bin/awk -f
> >>> On some distributions (debian) it is /usr/bin/awk.
> >> True, but on most of them (all?) there is also an appropriate link in /bin.
> > Nope, not on debian testing. Although I assume if kernel compilation
> > will start to fail it will appear :)
> >
> >> If shebang could have more that one argument, then '/usr/bin/env awk
> >> -f' would be the best solution I think.
>
> Ah, I see.
> Actually, it will be executed from Makefile with 'awk -f'.
>
> > --- a/arch/x86/lib/Makefile
> > +++ b/arch/x86/lib/Makefile
> > @@ -2,12 +2,21 @@
> > # Makefile for x86 specific library files.
> > #
> >
> > +quiet_cmd_inat_tables = GEN $@
> > + cmd_inat_tables = awk -f $(srctree)/arch/x86/scripts/gen-insn-attr-x86.awk $(srctree)/arch/x86/lib/x86-opcode-map.txt > $@
> > +
>
> So, if awk is on the PATH, it will pass.
Ah, that is good enough I thing. I tried to run scrip manually.

> Maybe, I need to add 'HOSTAWK = awk' line in Makefile.
>

--
Gleb.