From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mel Gorman <mel@csn.ul.ie>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86: Sanity check the e820 against the SRAT table using e820 map only
Date: Mon, 11 May 2009 08:51:24 -0700 [thread overview]
Message-ID: <4A08497C.8010203@kernel.org> (raw)
In-Reply-To: <20090511093612.GD26444@elte.hu>
Ingo Molnar wrote:
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
>> - e820ram = max_pfn - absent_pages_in_range(0, max_pfn);
>> + e820ram = max_pfn - (e820_hole_size(0, max_pfn<<PAGE_SHIFT)>>PAGE_SHIFT);
>
> btw., it would be nice to have a debug check that prints a warning
> if the SRAT does not cover all RAM, or if it covers RAM that is not
> present in the e820 map. Such a warning might alert us to double
> check all the PXM settings in the SRAT and could uncover more quirks
> like the above ...
we trust e820 than SRAT mem entries.
so early_node_map already are result of in e820 range AND srat. (the range in SRAT that is not in e820 is dumped)
just check srat table (without AND) with e820 will have some confusing. because SRAT would cover the hole below 4g that is not in E820.
YH
next prev parent reply other threads:[~2009-05-11 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 16:53 [PATCH] x86: fix nodes_cover_memory Yinghai Lu
2009-05-07 13:47 ` Mel Gorman
2009-05-07 14:21 ` Ingo Molnar
2009-05-07 14:47 ` Mel Gorman
2009-05-08 7:36 ` [PATCH 1/2] x86: Sanity check the e820 against the SRAT table using e820 map only Yinghai Lu
2009-05-08 7:37 ` [PATCH 2/2] x86: Allow 1MB of slack between the e820 map and SRAT, not 4GB Yinghai Lu
2009-05-11 9:54 ` [tip:x86/mm] " tip-bot for Yinghai Lu
2009-05-11 9:36 ` [PATCH 1/2] x86: Sanity check the e820 against the SRAT table using e820 map only Ingo Molnar
2009-05-11 15:51 ` Yinghai Lu [this message]
2009-05-11 9:54 ` [tip:x86/mm] " tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A08497C.8010203@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox