* linux-next: Tree for May 11
@ 2009-05-11 6:14 Stephen Rothwell
2009-05-11 16:32 ` [PATCH -next] kvm: fix build error: add missing semi-colon Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Stephen Rothwell @ 2009-05-11 6:14 UTC (permalink / raw)
To: linux-next; +Cc: LKML
[-- Attachment #1: Type: text/plain, Size: 7506 bytes --]
Hi all,
Changes since 20090508:
The infiniband tree lost its build failure.
The net tree lost a conflict.
The dwmw2-iommu tree gained a conflict against the x86 tree.
----------------------------------------------------------------------------
I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
(patches at
http://www.kernel.org/pub/linux/kernel/people/sfr/linux-next/). If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one. You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).
You can see which trees have been included by looking in the Next/Trees
file in the source. There are also quilt-import.log and merge.log files
in the Next directory. Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig (32 and
64 bit), ppc44x_defconfig and allyesconfig (minus
CONFIG_PROFILE_ALL_BRANCHES) and i386, sparc and sparc64 defconfig.
These builds also have CONFIG_ENABLE_WARN_DEPRECATED,
CONFIG_ENABLE_MUST_CHECK and CONFIG_DEBUG_INFO disabled when necessary.
Below is a summary of the state of the merge.
We are up to 136 trees (counting Linus' and 18 trees of patches pending for
Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.
Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next . If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.
Thanks to Jan Dittmer for adding the linux-next tree to his build tests
at http://l4x.org/k/ , the guys at http://test.kernel.org/ and Randy
Dunlap for doing many randconfig builds.
There is a wiki covering stuff to do with linux-next at
http://linux.f-seidel.de/linux-next/pmwiki/ . Thanks to Frank Seidel.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
$ git checkout master
$ git reset --hard stable
Merging origin/master
Merging fixes/fixes
Merging arm-current/master
Merging m68k-current/for-linus
Merging powerpc-merge/merge
Merging sparc-current/master
Merging scsi-rc-fixes/master
Merging net-current/master
Merging sound-current/for-linus
Merging pci-current/for-linus
Merging wireless-current/master
Merging kbuild-current/master
Merging quilt/driver-core.current
Merging quilt/usb.current
Merging cpufreq-current/fixes
Merging input-current/for-linus
Merging md-current/for-linus
Merging audit-current/for-linus
Merging crypto-current/master
Merging dwmw2/master
Merging arm/devel
CONFLICT (content): Merge conflict in arch/arm/Kconfig
Merging avr32/avr32-arch
Merging blackfin/for-linus
Merging cris/for-next
Merging ia64/test
Merging m68k/for-next
Merging m68knommu/for-next
Merging mips/mips-for-linux-next
Merging parisc/master
Merging powerpc/next
Merging 4xx/next
Merging galak/next
Merging pxa/for-next
Merging s390/features
Merging sh/master
Merging sparc/master
Merging x86/auto-x86-next
Merging xtensa/master
Merging configfs/linux-next
Merging ext4/next
Merging fatfs/master
Merging fuse/for-next
Merging gfs2/master
Merging jfs/next
Merging nfs/linux-next
Merging nfsd/nfsd-next
Merging nilfs2/for-next
Merging ocfs2/linux-next
Merging squashfs/master
Merging v9fs/for-next
CONFLICT (content): Merge conflict in net/9p/protocol.c
Merging ubifs/linux-next
Merging xfs/master
Merging tip-core/auto-core-next
Merging cpus4096/auto-cpus4096-next
Merging tracing/auto-tracing-next
Merging genirq/auto-genirq-next
Merging safe-poison-pointers/auto-safe-poison-pointers-next
Merging sched/auto-sched-next
Merging stackprotector/auto-stackprotector-next
Merging timers/auto-timers-next
Merging pci/linux-next
Merging quilt/device-mapper
Merging hid/for-next
Merging quilt/i2c
Merging quilt/jdelvare-hwmon
Merging quilt/kernel-doc
Merging v4l-dvb/master
Merging quota/for_next
Merging kbuild/master
[master 7ed7512] Revert "initconst adjustments"
Merging ide/for-next
Merging libata/NEXT
Merging infiniband/for-next
Merging acpi/test
Merging ieee1394/for-next
Merging ubi/linux-next
Merging kvm/master
Merging dlm/next
Merging scsi/master
CONFLICT (content): Merge conflict in include/Kbuild
Merging async_tx/next
Merging udf/for_next
Merging net/master
CONFLICT (content): Merge conflict in include/linux/mmc/sdio_ids.h
Merging wireless/master
[master fbdc23d] Revert "rfkill: remove user_claim stuff"
Merging mtd/master
Merging crypto/master
Merging vfs/for-next
CONFLICT (content): Merge conflict in fs/fuse/inode.c
Merging sound/for-next
Merging cpufreq/next
Merging quilt/rr
CONFLICT (content): Merge conflict in arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
Merging cifs/master
Merging mmc/next
Merging input/next
Merging bkl-removal/bkl-removal
Merging lsm/for-next
Merging block/for-next
CONFLICT (content): Merge conflict in drivers/block/hd.c
CONFLICT (content): Merge conflict in drivers/block/mg_disk.c
Merging embedded/master
Merging firmware/master
Merging pcmcia/master
Merging battery/master
Merging leds/for-mm
Merging backlight/for-mm
Merging kgdb/kgdb-next
Merging slab/for-next
Merging uclinux/for-next
Merging md/for-next
Merging mfd/for-next
Merging hdlc/hdlc-next
Merging drm/drm-next
Merging voltage/for-next
Merging security-testing/next
Merging lblnet/master
Merging quilt/ttydev
Merging agp/agp-next
Merging generic-ipi/auto-generic-ipi-next
Merging oprofile/auto-oprofile-next
Merging fastboot/auto-fastboot-next
Merging sparseirq/auto-sparseirq-next
Merging iommu/auto-iommu-next
Merging uwb/for-upstream
Merging watchdog/master
Merging bdev/master
Merging dwmw2-iommu/master
CONFLICT (content): Merge conflict in drivers/pci/intel-iommu.c
CONFLICT (content): Merge conflict in drivers/pci/intr_remapping.c
Merging cputime/cputime
Merging osd/linux-next
Merging jc_docs/docs-next
Merging nommu/master
Merging trivial/for-next
Merging audit/for-next
Merging omap/for-next
Merging quilt/aoe
Merging kmemleak/kmemleak
CONFLICT (delete/modify): arch/x86/kernel/vmlinux_32.lds.S deleted in HEAD and modified in kmemleak/kmemleak. Version kmemleak/kmemleak of arch/x86/kernel/vmlinux_32.lds.S left in tree.
CONFLICT (delete/modify): arch/x86/kernel/vmlinux_64.lds.S deleted in HEAD and modified in kmemleak/kmemleak. Version kmemleak/kmemleak of arch/x86/kernel/vmlinux_64.lds.S left in tree.
CONFLICT (content): Merge conflict in lib/Kconfig.debug
CONFLICT (content): Merge conflict in mm/slob.c
$ git rm -f arch/x86/kernel/vmlinux_32.lds.S arch/x86/kernel/vmlinux_64.lds.S
Applying: kmemleak: fixup for x86 vmlinux.ld.S merge
Merging suspend/linux-next
Merging bluetooth/master
Merging quilt/driver-core
CONFLICT (content): Merge conflict in init/main.c
Merging quilt/usb
CONFLICT (content): Merge conflict in drivers/usb/serial/sierra.c
Merging quilt/staging
CONFLICT (content): Merge conflict in drivers/staging/rt2860/common/mlme.c
CONFLICT (content): Merge conflict in drivers/staging/rt2870/common/mlme.c
CONFLICT (content): Merge conflict in drivers/staging/rt2870/rt2870.h
CONFLICT (content): Merge conflict in drivers/staging/rt3070/common/mlme.c
Merging scsi-post-merge/master
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next] kvm: fix build error: add missing semi-colon
2009-05-11 6:14 linux-next: Tree for May 11 Stephen Rothwell
@ 2009-05-11 16:32 ` Randy Dunlap
2009-05-12 8:31 ` Avi Kivity
2009-05-11 16:36 ` [PATCH -next] soc_camera: depends on I2C Randy Dunlap
2009-05-11 16:37 ` [PATCH -next] v4l2: handle unregister for non-I2C builds Randy Dunlap
2 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2009-05-11 16:32 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, avi, kvm@vger.kernel.org, Andrew Morton
From: Randy Dunlap <randy.dunlap@oracle.com>
Add missing ; to fix build error:
arch/x86/kvm/x86.c:1259: error: expected',' or ';' before 'const'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/x86/kvm/x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20090511.orig/arch/x86/kvm/x86.c
+++ linux-next-20090511/arch/x86/kvm/x86.c
@@ -1252,7 +1252,7 @@ static void do_cpuid_ent(struct kvm_cpui
#ifdef CONFIG_X86_64
unsigned f_lm = F(LM);
#else
- unsigned f_lm = 0
+ unsigned f_lm = 0;
#endif
/* cpuid 1.edx */
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next] soc_camera: depends on I2C
2009-05-11 6:14 linux-next: Tree for May 11 Stephen Rothwell
2009-05-11 16:32 ` [PATCH -next] kvm: fix build error: add missing semi-colon Randy Dunlap
@ 2009-05-11 16:36 ` Randy Dunlap
2009-05-11 17:53 ` Guennadi Liakhovetski
2009-05-11 16:37 ` [PATCH -next] v4l2: handle unregister for non-I2C builds Randy Dunlap
2 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2009-05-11 16:36 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, g.liakhovetski, linux-media,
Mauro Carvalho Chehab
From: Randy Dunlap <randy.dunlap@oracle.com>
soc_camera uses i2c_*() functions and has build errors when CONFIG_I2C=n:
ERROR: "i2c_new_device" [drivers/media/video/soc_camera.ko] undefined!
ERROR: "i2c_get_adapter" [drivers/media/video/soc_camera.ko] undefined!
ERROR: "i2c_put_adapter" [drivers/media/video/soc_camera.ko] undefined!
ERROR: "i2c_unregister_device" [drivers/media/video/soc_camera.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/media/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20090511.orig/drivers/media/video/Kconfig
+++ linux-next-20090511/drivers/media/video/Kconfig
@@ -694,7 +694,7 @@ config VIDEO_CAFE_CCIC
config SOC_CAMERA
tristate "SoC camera support"
- depends on VIDEO_V4L2 && HAS_DMA
+ depends on VIDEO_V4L2 && HAS_DMA && I2C
select VIDEOBUF_GEN
help
SoC Camera is a common API to several cameras, not connecting
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next] v4l2: handle unregister for non-I2C builds
2009-05-11 6:14 linux-next: Tree for May 11 Stephen Rothwell
2009-05-11 16:32 ` [PATCH -next] kvm: fix build error: add missing semi-colon Randy Dunlap
2009-05-11 16:36 ` [PATCH -next] soc_camera: depends on I2C Randy Dunlap
@ 2009-05-11 16:37 ` Randy Dunlap
2009-05-22 5:48 ` Paul Mundt
2 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2009-05-11 16:37 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, linux-media, Mauro Carvalho Chehab
From: Randy Dunlap <randy.dunlap@oracle.com>
Build fails when CONFIG_I2C=n, so handle that case in the if block:
drivers/built-in.o: In function `v4l2_device_unregister':
(.text+0x157821): undefined reference to `i2c_unregister_device'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/media/video/v4l2-device.c | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20090511.orig/drivers/media/video/v4l2-device.c
+++ linux-next-20090511/drivers/media/video/v4l2-device.c
@@ -85,6 +85,7 @@ void v4l2_device_unregister(struct v4l2_
/* Unregister subdevs */
list_for_each_entry_safe(sd, next, &v4l2_dev->subdevs, list) {
v4l2_device_unregister_subdev(sd);
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
if (sd->flags & V4L2_SUBDEV_FL_IS_I2C) {
struct i2c_client *client = v4l2_get_subdevdata(sd);
@@ -95,6 +96,7 @@ void v4l2_device_unregister(struct v4l2_
if (client)
i2c_unregister_device(client);
}
+#endif
}
}
EXPORT_SYMBOL_GPL(v4l2_device_unregister);
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -next] soc_camera: depends on I2C
2009-05-11 16:36 ` [PATCH -next] soc_camera: depends on I2C Randy Dunlap
@ 2009-05-11 17:53 ` Guennadi Liakhovetski
0 siblings, 0 replies; 10+ messages in thread
From: Guennadi Liakhovetski @ 2009-05-11 17:53 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Linux Media Mailing List,
Mauro Carvalho Chehab
On Mon, 11 May 2009, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> soc_camera uses i2c_*() functions and has build errors when CONFIG_I2C=n:
>
> ERROR: "i2c_new_device" [drivers/media/video/soc_camera.ko] undefined!
> ERROR: "i2c_get_adapter" [drivers/media/video/soc_camera.ko] undefined!
> ERROR: "i2c_put_adapter" [drivers/media/video/soc_camera.ko] undefined!
> ERROR: "i2c_unregister_device" [drivers/media/video/soc_camera.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks, applied.
Guennadi
> ---
> drivers/media/video/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20090511.orig/drivers/media/video/Kconfig
> +++ linux-next-20090511/drivers/media/video/Kconfig
> @@ -694,7 +694,7 @@ config VIDEO_CAFE_CCIC
>
> config SOC_CAMERA
> tristate "SoC camera support"
> - depends on VIDEO_V4L2 && HAS_DMA
> + depends on VIDEO_V4L2 && HAS_DMA && I2C
> select VIDEOBUF_GEN
> help
> SoC Camera is a common API to several cameras, not connecting
>
>
> --
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -next] kvm: fix build error: add missing semi-colon
2009-05-11 16:32 ` [PATCH -next] kvm: fix build error: add missing semi-colon Randy Dunlap
@ 2009-05-12 8:31 ` Avi Kivity
0 siblings, 0 replies; 10+ messages in thread
From: Avi Kivity @ 2009-05-12 8:31 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, kvm@vger.kernel.org,
Andrew Morton
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add missing ; to fix build error:
>
> arch/x86/kvm/x86.c:1259: error: expected',' or ';' before 'const'
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -next] v4l2: handle unregister for non-I2C builds
2009-05-11 16:37 ` [PATCH -next] v4l2: handle unregister for non-I2C builds Randy Dunlap
@ 2009-05-22 5:48 ` Paul Mundt
2009-05-22 7:55 ` Stephen Rothwell
0 siblings, 1 reply; 10+ messages in thread
From: Paul Mundt @ 2009-05-22 5:48 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, linux-media,
Mauro Carvalho Chehab
On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Build fails when CONFIG_I2C=n, so handle that case in the if block:
>
> drivers/built-in.o: In function `v4l2_device_unregister':
> (.text+0x157821): undefined reference to `i2c_unregister_device'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
This patch still has not been applied as far as I can tell, and builds
are still broken as a result, almost 2 weeks after the fact.
> ---
> drivers/media/video/v4l2-device.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20090511.orig/drivers/media/video/v4l2-device.c
> +++ linux-next-20090511/drivers/media/video/v4l2-device.c
> @@ -85,6 +85,7 @@ void v4l2_device_unregister(struct v4l2_
> /* Unregister subdevs */
> list_for_each_entry_safe(sd, next, &v4l2_dev->subdevs, list) {
> v4l2_device_unregister_subdev(sd);
> +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
> if (sd->flags & V4L2_SUBDEV_FL_IS_I2C) {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
>
> @@ -95,6 +96,7 @@ void v4l2_device_unregister(struct v4l2_
> if (client)
> i2c_unregister_device(client);
> }
> +#endif
> }
> }
> EXPORT_SYMBOL_GPL(v4l2_device_unregister);
>
>
> --
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -next] v4l2: handle unregister for non-I2C builds
2009-05-22 5:48 ` Paul Mundt
@ 2009-05-22 7:55 ` Stephen Rothwell
2009-05-22 15:57 ` Randy Dunlap
2009-05-26 17:31 ` Mauro Carvalho Chehab
0 siblings, 2 replies; 10+ messages in thread
From: Stephen Rothwell @ 2009-05-22 7:55 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Paul Mundt, Randy Dunlap, linux-next, LKML, linux-media,
Hans Verkuil
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
On Fri, 22 May 2009 14:48:47 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
>
> On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Build fails when CONFIG_I2C=n, so handle that case in the if block:
> >
> > drivers/built-in.o: In function `v4l2_device_unregister':
> > (.text+0x157821): undefined reference to `i2c_unregister_device'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> This patch still has not been applied as far as I can tell, and builds
> are still broken as a result, almost 2 weeks after the fact.
In fact there has been no updates to the v4l-dvb tree at all since
May 11. Mauro?
I have reverted the patch that caused the build breakage ... (commit
d5bc7940d39649210f1affac1fa32f253cc45a81 "V4L/DVB (11673): v4l2-device:
unregister i2c_clients when unregistering the v4l2_device").
[By the way, an alternative fix might be to just define
V4L2_SUBDEV_FL_IS_I2C to be zero if CONFIG_I2C and CONFIG_I2C_MODULE are
not defined (gcc should then just elide the offending code).]
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -next] v4l2: handle unregister for non-I2C builds
2009-05-22 7:55 ` Stephen Rothwell
@ 2009-05-22 15:57 ` Randy Dunlap
2009-05-26 17:31 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2009-05-22 15:57 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mauro Carvalho Chehab, Paul Mundt, linux-next, LKML, linux-media,
Hans Verkuil
Stephen Rothwell wrote:
> On Fri, 22 May 2009 14:48:47 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
>> On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> Build fails when CONFIG_I2C=n, so handle that case in the if block:
>>>
>>> drivers/built-in.o: In function `v4l2_device_unregister':
>>> (.text+0x157821): undefined reference to `i2c_unregister_device'
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> This patch still has not been applied as far as I can tell, and builds
>> are still broken as a result, almost 2 weeks after the fact.
>
> In fact there has been no updates to the v4l-dvb tree at all since
> May 11. Mauro?
I got an 'hg' autocommit message for the patch on May-11, but that's
all I've seen/heard about it.
I'm really concerned about how slowly patches are merged for
linux-next trees... and not just for drivers/media/
> I have reverted the patch that caused the build breakage ... (commit
> d5bc7940d39649210f1affac1fa32f253cc45a81 "V4L/DVB (11673): v4l2-device:
> unregister i2c_clients when unregistering the v4l2_device").
>
> [By the way, an alternative fix might be to just define
> V4L2_SUBDEV_FL_IS_I2C to be zero if CONFIG_I2C and CONFIG_I2C_MODULE are
> not defined (gcc should then just elide the offending code).]
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -next] v4l2: handle unregister for non-I2C builds
2009-05-22 7:55 ` Stephen Rothwell
2009-05-22 15:57 ` Randy Dunlap
@ 2009-05-26 17:31 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 10+ messages in thread
From: Mauro Carvalho Chehab @ 2009-05-26 17:31 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Paul Mundt, Randy Dunlap, linux-next, LKML, linux-media,
Hans Verkuil
Em Fri, 22 May 2009 17:55:54 +1000
Stephen Rothwell <sfr@canb.auug.org.au> escreveu:
> On Fri, 22 May 2009 14:48:47 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
> >
> > On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > Build fails when CONFIG_I2C=n, so handle that case in the if block:
> > >
> > > drivers/built-in.o: In function `v4l2_device_unregister':
> > > (.text+0x157821): undefined reference to `i2c_unregister_device'
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > This patch still has not been applied as far as I can tell, and builds
> > are still broken as a result, almost 2 weeks after the fact.
>
> In fact there has been no updates to the v4l-dvb tree at all since
> May 11. Mauro?
Sorry, this email were got by a wrong filtering rule here. Only today I
noticed it.
Anyway, the tree were updated yesterday, with Randy's patch. Sorry for the mess.
>
> I have reverted the patch that caused the build breakage ... (commit
> d5bc7940d39649210f1affac1fa32f253cc45a81 "V4L/DVB (11673): v4l2-device:
> unregister i2c_clients when unregistering the v4l2_device").
>
> [By the way, an alternative fix might be to just define
> V4L2_SUBDEV_FL_IS_I2C to be zero if CONFIG_I2C and CONFIG_I2C_MODULE are
> not defined (gcc should then just elide the offending code).]
Cheers,
Mauro
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-05-26 17:31 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-11 6:14 linux-next: Tree for May 11 Stephen Rothwell
2009-05-11 16:32 ` [PATCH -next] kvm: fix build error: add missing semi-colon Randy Dunlap
2009-05-12 8:31 ` Avi Kivity
2009-05-11 16:36 ` [PATCH -next] soc_camera: depends on I2C Randy Dunlap
2009-05-11 17:53 ` Guennadi Liakhovetski
2009-05-11 16:37 ` [PATCH -next] v4l2: handle unregister for non-I2C builds Randy Dunlap
2009-05-22 5:48 ` Paul Mundt
2009-05-22 7:55 ` Stephen Rothwell
2009-05-22 15:57 ` Randy Dunlap
2009-05-26 17:31 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox