From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756715AbZEKQe5 (ORCPT ); Mon, 11 May 2009 12:34:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753087AbZEKQeq (ORCPT ); Mon, 11 May 2009 12:34:46 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:53226 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752917AbZEKQep (ORCPT ); Mon, 11 May 2009 12:34:45 -0400 Message-ID: <4A0853FE.6060709@oracle.com> Date: Mon, 11 May 2009 09:36:14 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Stephen Rothwell CC: linux-next@vger.kernel.org, LKML , g.liakhovetski@gmx.de, linux-media@vger.kernel.org, Mauro Carvalho Chehab Subject: [PATCH -next] soc_camera: depends on I2C References: <20090511161442.3e9d9cb9.sfr@canb.auug.org.au> In-Reply-To: <20090511161442.3e9d9cb9.sfr@canb.auug.org.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: abhmt005.oracle.com [141.146.116.14] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010207.4A085388.00D8:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap soc_camera uses i2c_*() functions and has build errors when CONFIG_I2C=n: ERROR: "i2c_new_device" [drivers/media/video/soc_camera.ko] undefined! ERROR: "i2c_get_adapter" [drivers/media/video/soc_camera.ko] undefined! ERROR: "i2c_put_adapter" [drivers/media/video/soc_camera.ko] undefined! ERROR: "i2c_unregister_device" [drivers/media/video/soc_camera.ko] undefined! Signed-off-by: Randy Dunlap --- drivers/media/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20090511.orig/drivers/media/video/Kconfig +++ linux-next-20090511/drivers/media/video/Kconfig @@ -694,7 +694,7 @@ config VIDEO_CAFE_CCIC config SOC_CAMERA tristate "SoC camera support" - depends on VIDEO_V4L2 && HAS_DMA + depends on VIDEO_V4L2 && HAS_DMA && I2C select VIDEOBUF_GEN help SoC Camera is a common API to several cameras, not connecting -- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/