Re: [tip:irq/numa] x86: read apic ID in the !acpi_lapic case

Ingo Molnar
2009-05-12T19:06:26Z

* Yinghai Lu <yinghai@kernel.org> wrote:

> Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@kernel.org> wrote:
> >
> >> Ingo Molnar wrote:
> >>> got this on a testbox:
> >>>
> >>> [ 0.113333] WARNING: at arch/x86/kernel/apic/apic.c:253 warn_slowpath_null+0x28/0x50()
> >>>
> >>> Ingo
> >>>
> >>> [ 0.000000] Initializing cgroup subsys cpuset
> >>> [ 0.000000] Linux version 2.6.30-rc5-tip-01553-g4bc9bac-dirty (mingo@sirius) (gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC) ) #48764 SMP PREEMPT Tue May 12 18:30:18 CEST 2009
> >>> [ 0.000000] Command line: root=/dev/sda1 earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 console=tty debug initcall_debug apic=verbose sysrq_always_enabled 5 ignore_loglevel nosmp no_hz=off highres=0 nmi_watchdog=0 noapic nolapic_timer hpet=disable idle=poll notsc acpi=off
> >> you should use
> >> nolapic and noapic_timer
> >>
> >> /* same as disableapic, for compatibility */
> >> static int __init setup_nolapic(char *arg)
> >> {
> >> return setup_disableapic(arg);
> >> }
> >> early_param("nolapic", setup_nolapic);
> >>
> >> static int __init parse_disable_apic_timer(char *arg)
> >> {
> >> disable_apic_timer = 1;
> >> return 0;
> >> }
> >> early_param("noapictimer", parse_disable_apic_timer);
> >
> > What do you mean? This warning never triggered before on this
> > test-box. This is a plain regression.
>
> just a reminder: that in your command there are some typo: should
> use nolapic and noapic_timer.

ah, ok - indeed. But that is irrelevant to the bugreport.

Ingo