Re: [tip:irq/numa] x86: read apic ID in the !acpi_lapic case

Yinghai Lu
2009-05-12T17:13:23Z

Cyrill Gorcunov wrote:
> [Ingo Molnar - Tue, May 12, 2009 at 06:46:17PM +0200]
> |
> | got this on a testbox:
> |
> | [ 0.113333] WARNING: at arch/x86/kernel/apic/apic.c:253 warn_slowpath_null+0x28/0x50()
> |
> | Ingo
> |
>
> It's expected (unfortunately). If we have SMP compiled kernel
> we still rely on apic_read heavily. Since for fake'ed apic
> we just return 0 for any reading I suspect we could just drop
> WARN_ON_ONCE for native_apic_read_dummy. Yinghai?
>
> (well, actually we should clean up callees but it would require
> some effort)

32bit seems doesn't have this warning.

and on 64bit, we always assumed have local APIC there. so could be that noapic is not cleanly enforced

YH