From: Jeff Garzik <jeff@garzik.org>
To: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
Jeff Garzik <jgarzik@redhat.com>
Subject: Re: [PATCH] Avoid world-writable sysfs files in libata driver
Date: Mon, 11 May 2009 14:34:24 -0400 [thread overview]
Message-ID: <4A086FB0.5010605@garzik.org> (raw)
In-Reply-To: <878wld0yiq.wl%vmayatsk@redhat.com>
Vitaly Mayatskikh wrote:
> Avoid world-writable sysfs files in libata driver.
>
> Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
> ---
> drivers/ata/libata-scsi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 2733b0c..68d9132 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -313,7 +313,7 @@ ata_scsi_em_message_show(struct device *dev, struct device_attribute *attr,
> return ap->ops->em_show(ap, buf);
> return -EINVAL;
> }
> -DEVICE_ATTR(em_message, S_IRUGO | S_IWUGO,
> +DEVICE_ATTR(em_message, S_IRUGO | S_IWUSR,
> ata_scsi_em_message_show, ata_scsi_em_message_store);
> EXPORT_SYMBOL_GPL(dev_attr_em_message);
>
> @@ -366,7 +366,7 @@ ata_scsi_activity_store(struct device *dev, struct device_attribute *attr,
> }
> return -EINVAL;
> }
> -DEVICE_ATTR(sw_activity, S_IWUGO | S_IRUGO, ata_scsi_activity_show,
> +DEVICE_ATTR(sw_activity, S_IWUSR | S_IRUGO, ata_scsi_activity_show,
applied
prev parent reply other threads:[~2009-05-11 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 13:48 [PATCH] Avoid world-writable sysfs files in libata driver Vitaly Mayatskikh
2009-05-11 18:34 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A086FB0.5010605@garzik.org \
--to=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v.mayatskih@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox