From: Michal Simek <monstr@monstr.eu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au
Subject: Re: [PATCH 11/12] microblaze: dont include asm/mmu.h in hw_exception_handler
Date: Tue, 12 May 2009 11:12:14 +0200 [thread overview]
Message-ID: <4A093D6E.7060309@monstr.eu> (raw)
In-Reply-To: <20090511232345.746701938@arndb.de>>
Arnd Bergmann wrote:
1. Please do not attach your patches - use in-line patches - it is easier for me and for others to
review it.
2. I have to reject this patch.
- currently you are right that I should remove mmu.h from hw_exception...S for noMMU kernel
- but on the other hand I need mmu.h for mmu patches - because of MICROBLAZE_TLB_SIZE
- if you think that mmu.h shouldn't be included we have to move this definition to another file
- you can look at my next branch to see mmu context
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
next prev parent reply other threads:[~2009-05-12 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090511232019.927138561@arndb.de>
[not found] ` <20090511232345.859696820@arndb.de>
2009-05-11 23:59 ` [microblaze-uclinux] [PATCH 12/12] microblaze: use generic dma-mapping-broken.h Stephen Neuendorffer
2009-05-12 0:29 ` Arnd Bergmann
2009-05-12 0:33 ` Stephen Neuendorffer
[not found] ` <20090511232345.746701938@arndb.de>
2009-05-12 9:12 ` Michal Simek [this message]
2009-05-12 11:13 ` [PATCH 11/12] microblaze: dont include asm/mmu.h in hw_exception_handler Arnd Bergmann
2009-05-12 11:24 ` Michal Simek
2009-05-12 11:46 ` Arnd Bergmann
2009-05-12 9:27 ` [PATCH 00/12] Microblaze fixes for 2.6.31 Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A093D6E.7060309@monstr.eu \
--to=monstr@monstr.eu \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox