Re: [PATCH 03/11] block: add rq->resid_len

Tejun Heo
2009-05-12T15:23:26Z

Boaz Harrosh wrote:

> The solution to this, I think, is that the bouncing layer should
> receive a residual count, and not bounce anything beyond what's
> transferred. (On reads, writes does nothing), and zero-out the
> rest. This of course means that all block drivers make sure residual
> is properly set, the way it should as explained in this
> thread. (SCSI does the right thing where it can, for example see
> scsi_execute())

Umm... shouldn't the request just be successfully finished with
positive residue count and with sense data if necessary? Block layer
request failure means, and has always meant, complete failure.

Thanks.

--
tejun