public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
	jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
	benh@kernel.crashing.org
Subject: Re: [PATCH] swim3: use blk_end_request instead of blk_update_request
Date: Wed, 13 May 2009 00:27:30 +0900	[thread overview]
Message-ID: <4A099562.7020805@kernel.org> (raw)
In-Reply-To: <4A098B8D.10107@panasas.com>

Hello,

Boaz Harrosh wrote:
> blk_update_request() was meant for request-based-multi-path, and not for swim3
> please see:
>     32fab448 block: add request update interface
> 
> CC: Kiyoshi Ueda<k-ueda@ct.jp.nec.com>
> 
> I think Tejun Heo was just using that in some recent block layer,
> transformation.
> Tejun?

Yeah, conversion was easy that way.  I think it's sane to have
blk_update_request() exported as long as request internal tinkering is
kept in block layer proper.

Thanks.

-- 
tejun

  parent reply	other threads:[~2009-05-12 15:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-12 11:29 [PATCH 0/2] swim3: use blk_end_request_all() FUJITA Tomonori
2009-05-12 11:29 ` [PATCH] swim3: use blk_end_request_all when we hit the maximum retry count FUJITA Tomonori
2009-05-12 11:29 ` [PATCH] swim3: use blk_end_request instead of blk_update_request FUJITA Tomonori
2009-05-12 14:45   ` Boaz Harrosh
2009-05-12 15:06     ` FUJITA Tomonori
2009-05-12 15:27     ` Tejun Heo [this message]
2009-05-13  0:50       ` Kiyoshi Ueda
2009-05-13  5:49         ` Jens Axboe
2009-05-13  5:52           ` Tejun Heo
2009-05-13  5:59             ` Jens Axboe
2009-05-12 15:25 ` [PATCH 0/2] swim3: use blk_end_request_all() Tejun Heo
2009-05-12 15:31   ` FUJITA Tomonori
2009-05-12 15:36     ` Tejun Heo
2009-05-12 15:51       ` FUJITA Tomonori
2009-05-12 22:58         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A099562.7020805@kernel.org \
    --to=tj@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=bharrosh@panasas.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jens.axboe@oracle.com \
    --cc=k-ueda@ct.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox