2.6.30-rc5: reiserfs is broken on parisc (bisected)

2.6.30-rc5: reiserfs is broken on parisc (bisected)

[Alexander Beregalov]

Hi

ab17c4f02156c4f75d7fa43a5aa2a7f942d47201 is the first bad commit
(reiserfs: fixup xattr_root caching)

Kernel panics when init tries to remount rootfs (reiserfs) with
read-write access.
Read-only access works fine.

No more messages on the screen before panic.

Is it endianess related?

Re: 2.6.30-rc5: reiserfs is broken on parisc (bisected)

[Jeff Mahoney]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Beregalov wrote:
> Hi
> 
> ab17c4f02156c4f75d7fa43a5aa2a7f942d47201 is the first bad commit
> (reiserfs: fixup xattr_root caching)
> 
> Kernel panics when init tries to remount rootfs (reiserfs) with
> read-write access.
> Read-only access works fine.
> 
> No more messages on the screen before panic.
> 
> Is it endianess related?

No, not at all. There was a problem with the xattr code if the kernel
was built with xattrs disabled. It assumed that
REISERFS_SB(s)->xattr_root would be available, which isn't the case when
xattrs aren't enabled. Part of it has been cleaned up in -git1, and I've
sent Al some additional patches to fix the rest of it up.

There's a thread called "reiserfs xattr fixups" that contains 4 patches.
The patch marked with * is the one I believe will fix your problem.

- - reiserfs: cleanup ifdefs
- - reiserfs: deal with NULL xattr root w/ xattrs disabled *
- - reiserfs: fixup perms when xattrs are disabled
- - reiserfs: allow exposing privroot w/ xattrs enabled

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkoJr9EACgkQLPWxlyuTD7JbfACfSV+WiMxReRCr/YRDT8IBf7M8
jVkAn3fhf3R1i5cyi/YJ+vtO/WTd6Lre
=90Xq
-----END PGP SIGNATURE-----

Re: 2.6.30-rc5: reiserfs is broken on parisc (bisected)

[Alexander Beregalov]

2009/5/12 Jeff Mahoney <jeffm@suse.com>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Alexander Beregalov wrote:
>> Hi
>>
>> ab17c4f02156c4f75d7fa43a5aa2a7f942d47201 is the first bad commit
>> (reiserfs: fixup xattr_root caching)
>>
>> Kernel panics when init tries to remount rootfs (reiserfs) with
>> read-write access.
>> Read-only access works fine.
>>
>> No more messages on the screen before panic.
>>
>> Is it endianess related?
>
> No, not at all. There was a problem with the xattr code if the kernel
> was built with xattrs disabled. It assumed that
> REISERFS_SB(s)->xattr_root would be available, which isn't the case when
> xattrs aren't enabled. Part of it has been cleaned up in -git1, and I've
> sent Al some additional patches to fix the rest of it up.
>
> There's a thread called "reiserfs xattr fixups" that contains 4 patches.
> The patch marked with * is the one I believe will fix your problem.
>
> - - reiserfs: cleanup ifdefs
> - - reiserfs: deal with NULL xattr root w/ xattrs disabled *
> - - reiserfs: fixup perms when xattrs are disabled
> - - reiserfs: allow exposing privroot w/ xattrs enabled
>
It works!
Thanks Jeff.